Skip to content

fix: show deprecated error for alias #40961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2020
Merged

fix: show deprecated error for alias #40961

merged 1 commit into from
Oct 12, 2020

Conversation

a-tarasyuk
Copy link
Contributor

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 6, 2020
sandersn
sandersn requested changes Oct 9, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the suggestions, does it? It looks like it's just the suggestions.

Also one style request.

@a-tarasyuk a-tarasyuk force-pushed the fix/deprecated-alias branch from 7ad32c9 to f6d1203 Compare October 10, 2020 07:35
@a-tarasyuk
Copy link
Contributor Author

@sandersn Yes, this is a fix for the issue described in the #40588 (comment).

@a-tarasyuk a-tarasyuk requested a review from sandersn October 10, 2020 08:05
@sandersn sandersn merged commit 05be3b4 into microsoft:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated suggestions not reported as deprecated imported alias
3 participants
@a-tarasyuk @sandersn @typescript-bot