go-to-type-definition, and find-all-refs should work for import.meta

[Zzzen]

Fixes #24353

IIUC, import.meta have no corresponding symbol, and the general algorithm (find the symbol of node, find the type/references of symbol) will not work. So I just intercept them in the services.

[DanielRosenwasser]

This doesn't work in the presence of whitespace.

let x = import
  .  // hai :)
    meta;

I would change your search string to meta instead.

[DanielRosenwasser]

This looks good! I think I mostly just have a nit regarding what we consider a "definition" reference.

[DanielRosenwasser]

I don't exactly know if you should be considering anything a "definition" location apart from the global ImportMeta interface.

Even that one is a little weird, because that's what you'd want if you requested "go-to-type", not necessarily "go-to-definition".

Do all responses require a definition? @jessetrinity and @andrewbranch might have more knowledge here.

[andrewbranch]

The types imply that a definition isn’t required. My intuition is that this shouldn’t be one.

[Zzzen]

It's copied from getAllReferencesForKeyword, which searches primitive types like string/number/any. They should have no definition either?

function getAllReferencesForKeyword(sourceFiles: readonly SourceFile[], keywordKind: SyntaxKind, cancellationToken: CancellationToken, filter?: (node: Node) => boolean): SymbolAndEntries[] | undefined {
    // ...
    return references.length ? [{ definition: { type: DefinitionKind.Keyword, node: references[0].node }, references }] : undefined;
}

[andrewbranch]

I’m not 100% sure what the implications are for removing it—we should check with @mjbvz ad @uniqueiniquity.

[andrewbranch]

Let’s get rid of the definition

[Zzzen]

Only include referenced symbols that have a valid definition.

findReferencedSymbols won't work if definition is absent.

TypeScript/src/services/findAllReferences.ts

Lines 207 to 219 in 29c7ae2

	export function findReferencedSymbols(program: Program, cancellationToken: CancellationToken, sourceFiles: readonly SourceFile[], sourceFile: SourceFile, position: number): ReferencedSymbol[] | undefined {
	const node = getTouchingPropertyName(sourceFile, position);
	const referencedSymbols = Core.getReferencedSymbolsForNode(position, node, program, sourceFiles, cancellationToken, { use: FindReferencesUse.References });
	const checker = program.getTypeChecker();
	const symbol = checker.getSymbolAtLocation(node);
	return !referencedSymbols || !referencedSymbols.length ? undefined : mapDefined<SymbolAndEntries, ReferencedSymbol>(referencedSymbols, ({ definition, references }) =>
	// Only include referenced symbols that have a valid definition.
	definition && {
	definition: checker.runWithCancellationToken(cancellationToken, checker => definitionToReferencedSymbolDefinitionInfo(definition, checker, node)),
	references: references.map(r => toReferenceEntry(r, symbol))
	});
	}

[andrewbranch]

🤦 I swear all this stuff was just made up on the spot

[andrewbranch]

Let’s get rid of the definition

[andrewbranch]

Shouldn’t there be something here?

[Zzzen]

Ooops, it's empty because definition is removed. Currently definition is required. It might break vscode if we make it optional.

TypeScript/src/services/types.ts

Lines 1042 to 1045 in 733eff2

	export interface ReferencedSymbol {
	definition: ReferencedSymbolDefinitionInfo;
	references: ReferenceEntry[];
	}

[andrewbranch]

🤦 I swear all this stuff was just made up on the spot