Revisions for the new --help #44800

orta · 2021-06-29T13:01:04Z

Fixes #44798

src/executeCommandLine/executeCommandLine.ts

DanielRosenwasser · 2021-06-29T18:38:33Z

What's the before/after look like?

orta · 2021-06-29T21:30:28Z

There is 3 ways blue can show:

Terminal supports 256+ colors. We don't use the terminal theme blue, but use an ANSI constant which is close to TS blue, which works on dark/light terminals:

https://jonasjacek.github.io/colors/ - SteelBlue3 ANSI 68
Terminal supports 16 colors, this is windows console / powershell and probably some old school linux terminals
Is it Windows? Then use "Bright Blue"
Is it not Windows? Then use "Blue"

DanielRosenwasser · 2021-06-29T21:36:28Z

@typescript-bot pack this

typescript-bot · 2021-06-29T21:36:31Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at b8015ef. You can monitor the build here.

DanielRosenwasser · 2021-06-29T21:51:42Z

We don't use the terminal theme blue, but use an ANSI constant which is close to TS blue, which works on dark/light terminals:

For something with a pure white background (e.g. the default MacOS terminal theme) how does that look? On a white background, I'm getting a contrast ratio of 3.53 which is still fairly low.

Seems like if bright blue is this on CMD

and this is bright blue on PowerShell

that might work, though it's a bit off from brand colors.

typescript-bot · 2021-06-29T21:55:53Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/105942/artifacts?artifactName=tgz&fileId=F56CE154C3A2F891879AB5C6168315612816E538F151AB33B83481494114EA0002&fileName=/typescript-4.4.0-insiders.20210629.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

DanielRosenwasser · 2021-06-29T21:59:14Z

This seems to set the background color to blue.

and uh doesn't un-set it.

orta · 2021-06-30T06:50:47Z

hahaha, well, I guess I need to get a windows VM up and running 🍡

DanielRosenwasser · 2021-06-30T08:03:30Z

This is your big chance to tell us how you feel about Windows 11. 😅

orta · 2021-06-30T15:33:02Z

Hah, well it does look like Windows 11 doesn't ruin the UI by trying to make it touch focused - I believe that was a mistake made back in Windows 8 which I wish Apple had also learned. That said, the overall design of Win 11 feels like it falls into the same tailwindification design style that's pretty much everywhere on the web too, it looks nice but it's all just a bit samey. For OS design though, I can see that that can be an advantage.

Anyway to this PR, I got up a few VMs and explored a bunch of options. In the end, I just dramatically simplified everything and took out almost all cases of being clever. We use 'bright blue' for blue everywhere except powershell/command prompt. This has a solid contrast

'strong blue' in default themes for terminal/vscode:

'strong blue' fails in powershell though:

While I'd love to be able to target just powershell, I couldn't see any ENV differences between the two, and so they both get 'strong cyan' instead:

DanielRosenwasser · 2021-06-30T20:52:48Z

What are your thoughts on just using a brighter white if 256 color isn't available?

orta · 2021-06-30T21:08:43Z

I'm not offended, will switch it now

DanielRosenwasser · 2021-07-01T08:40:55Z

@typescript-bot pack this

typescript-bot · 2021-07-01T08:40:58Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 2c5a07d. You can monitor the build here.

typescript-bot · 2021-07-01T09:00:58Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/106056/artifacts?artifactName=tgz&fileId=2A9F5C67C72DBB2CDA4D7CDC7C10CF47309FA26B3E25D8DC044A7718057ED5E702&fileName=/typescript-4.4.0-insiders.20210701.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Gerrit0 · 2021-07-02T01:59:40Z

src/executeCommandLine/executeCommandLine.ts

@@ -90,32 +90,53 @@ namespace ts {
    }

    function createColors(sys: System) {
-        const showColors = defaultIsPretty(sys);
+        const showColors = defaultIsPretty(sys) || !!sys.getEnvironmentVariable("NO_COLOR");


This looks wrong. Shouldn't it be defaultIsPretty(sys) && !sys.getEnvironmentVariable("NO_COLOR")? If NO_COLOR exists, then we shouldn't print color... as is, if NO_COLOR is set, then tsc will write with colors even if it is not printing to a terminal.

(There's also the consideration that we should be checking for existence, not non-emptyness, but that's less important)

Coming back to this - I think the environment check belongs in the defaultIsPretty function... but maybe I don't understand that yet.

Thanks, yeah I was avoiding making more drastic changes by adding NO_COLOR support everywhere (somewhat making this bug-fix a feature) by moving it into defaultIsPretty - running the tests now too see how that changes the test suite.

(edit: looks like no changes)

orta · 2021-07-19T06:59:06Z

There are three different color rendering setup now: plain text, plain text + bold, color:

orta · 2021-07-19T07:04:45Z

I've switched to have NO_COLORin defaultIsPretty and added a test to verify the plain-text-ness of the output

DanielRosenwasser · 2021-08-03T17:53:03Z

@typescript-bot pack this

typescript-bot · 2021-08-03T17:53:09Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at c350c39. You can monitor the build here.

DanielRosenwasser

It would be nice to try this out first - I won't block on that though.

src/compiler/diagnosticMessages.json

DanielRosenwasser · 2021-08-03T17:52:13Z

src/testRunner/unittests/tsc/runWithoutArgs.ts

@@ -14,5 +14,14 @@ namespace ts {
            fs: () => loadProjectFromFiles({}),
            commandLineArgs: [],
        });
+
+        verifyTsc({


Seems like these tests generate a .js file - would be awesome if we could change that though.

typescript-bot · 2021-08-03T18:11:58Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/107935/artifacts?artifactName=tgz&fileId=35C0FBAAA434C08A4B9FECAB82DFF85F7EF760F2A9D597743E0081C08C1FEF1B02&fileName=/typescript-4.4.0-insiders.20210803.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Co-authored-by: Daniel Rosenwasser <[email protected]>

orta · 2021-08-05T15:40:57Z

Requests merged, I'm going to get this in so that it doesn't get overlooked before the RC

orta added 2 commits June 21, 2021 13:46

WIP on refining the new --help

36b5fa8

Merge upstream

d509129

typescript-bot assigned orta Jun 29, 2021

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 29, 2021

orta added 4 commits June 29, 2021 14:18

Fix types in the boolean trivial lint rule

33e935a

Merge commit '33e935a67d' into help_revisions

4b87338

Update baselines

126c3d4

More work

f09e43c

DanielRosenwasser reviewed Jun 29, 2021

View reviewed changes

src/executeCommandLine/executeCommandLine.ts Outdated Show resolved Hide resolved

Updates the color logic

b8015ef

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 29, 2021

orta added 2 commits June 30, 2021 15:55

Simplifies the CLI color code

3de5f6e

Use cyan instead of blue for win powershell/command prompt

aa1d04a

Use bright white when blue is probably going to look off

2c5a07d

Gerrit0 suggested changes Jul 2, 2021

View reviewed changes

Fix NO_COLOR

1485f11

Adds a test to cover NO_COLOR

c350c39

DanielRosenwasser approved these changes Aug 3, 2021

View reviewed changes

orta and others added 2 commits August 5, 2021 08:04

Update src/compiler/diagnosticMessages.json

88465b3

Co-authored-by: Daniel Rosenwasser <[email protected]>

Update compiler diagnostic text

c42bccb

orta merged commit 1f85123 into microsoft:main Aug 5, 2021

Revisions for the new --help #44800

Revisions for the new --help #44800

Uh oh!

Conversation

orta commented Jun 29, 2021

Uh oh!

Uh oh!

DanielRosenwasser commented Jun 29, 2021

Uh oh!

orta commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Jun 29, 2021

Uh oh!

typescript-bot commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Jun 29, 2021

Uh oh!

typescript-bot commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orta commented Jun 30, 2021

Uh oh!

DanielRosenwasser commented Jun 30, 2021

Uh oh!

orta commented Jun 30, 2021

Uh oh!

DanielRosenwasser commented Jun 30, 2021

Uh oh!

orta commented Jun 30, 2021

Uh oh!

DanielRosenwasser commented Jul 1, 2021

Uh oh!

typescript-bot commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gerrit0 Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

Gerrit0 Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

orta Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orta commented Jul 19, 2021

Uh oh!

orta commented Jul 19, 2021

Uh oh!

DanielRosenwasser commented Aug 3, 2021

Uh oh!

typescript-bot commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DanielRosenwasser Aug 3, 2021

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orta commented Aug 5, 2021

Uh oh!

Uh oh!

orta commented Jun 29, 2021 •

edited

Loading

typescript-bot commented Jun 29, 2021 •

edited

Loading

typescript-bot commented Jun 29, 2021 •

edited

Loading

DanielRosenwasser commented Jun 29, 2021 •

edited

Loading

typescript-bot commented Jul 1, 2021 •

edited

Loading

typescript-bot commented Jul 1, 2021 •

edited

Loading

orta Jul 19, 2021 •

edited

Loading

typescript-bot commented Aug 3, 2021 •

edited

Loading

typescript-bot commented Aug 3, 2021 •

edited

Loading