Skip to content

Fix check for generic types in control flow analysis #45148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2021
Merged

Fix check for generic types in control flow analysis #45148

merged 4 commits into from
Aug 6, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #45145.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 22, 2021
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 3aac11e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 3aac11e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at 3aac11e. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 3aac11e. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Jul 22, 2021
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..45148

Metric main 45148 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 348,498k (± 0.03%) 348,499k (± 0.02%) +1k (+ 0.00%) 348,326k 348,600k
Parse Time 1.81s (± 0.57%) 1.81s (± 0.44%) -0.00s (- 0.22%) 1.80s 1.83s
Bind Time 0.84s (± 0.90%) 0.84s (± 0.70%) 0.00s ( 0.00%) 0.83s 0.86s
Check Time 5.37s (± 0.72%) 5.34s (± 0.53%) -0.03s (- 0.50%) 5.28s 5.41s
Emit Time 5.85s (± 0.54%) 5.81s (± 0.32%) -0.04s (- 0.73%) 5.77s 5.85s
Total Time 13.88s (± 0.47%) 13.81s (± 0.28%) -0.07s (- 0.54%) 13.69s 13.87s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,376k (± 0.02%) 203,446k (± 0.04%) +70k (+ 0.03%) 203,202k 203,624k
Parse Time 0.78s (± 0.95%) 0.78s (± 0.79%) -0.00s (- 0.26%) 0.77s 0.79s
Bind Time 0.53s (± 1.27%) 0.52s (± 1.11%) -0.00s (- 0.76%) 0.51s 0.53s
Check Time 7.83s (± 0.69%) 7.82s (± 0.73%) -0.01s (- 0.10%) 7.71s 7.97s
Emit Time 2.43s (± 0.51%) 2.44s (± 0.70%) +0.01s (+ 0.45%) 2.41s 2.48s
Total Time 11.56s (± 0.51%) 11.56s (± 0.52%) -0.00s (- 0.00%) 11.45s 11.71s
Monaco - node (v10.16.3, x64)
Memory used 340,535k (± 0.03%) 340,548k (± 0.02%) +14k (+ 0.00%) 340,395k 340,700k
Parse Time 1.47s (± 1.01%) 1.45s (± 0.80%) -0.02s (- 1.09%) 1.43s 1.48s
Bind Time 0.75s (± 0.97%) 0.75s (± 0.91%) -0.00s (- 0.27%) 0.74s 0.77s
Check Time 5.38s (± 0.74%) 5.38s (± 0.66%) -0.00s (- 0.06%) 5.27s 5.46s
Emit Time 3.16s (± 0.86%) 3.16s (± 0.70%) +0.00s (+ 0.06%) 3.11s 3.20s
Total Time 10.76s (± 0.37%) 10.75s (± 0.37%) -0.02s (- 0.15%) 10.64s 10.86s
TFS - node (v10.16.3, x64)
Memory used 304,022k (± 0.02%) 304,004k (± 0.01%) -18k (- 0.01%) 303,967k 304,056k
Parse Time 1.19s (± 0.52%) 1.19s (± 0.75%) -0.00s (- 0.25%) 1.17s 1.21s
Bind Time 0.71s (± 0.70%) 0.71s (± 0.94%) -0.00s (- 0.28%) 0.70s 0.73s
Check Time 4.90s (± 0.40%) 4.89s (± 0.60%) -0.01s (- 0.20%) 4.84s 4.96s
Emit Time 3.32s (± 0.79%) 3.33s (± 1.83%) +0.01s (+ 0.36%) 3.25s 3.54s
Total Time 10.12s (± 0.34%) 10.12s (± 0.76%) -0.00s (- 0.01%) 10.00s 10.38s
material-ui - node (v10.16.3, x64)
Memory used 469,690k (± 0.01%) 469,636k (± 0.01%) -55k (- 0.01%) 469,518k 469,786k
Parse Time 1.74s (± 0.57%) 1.73s (± 0.34%) -0.01s (- 0.75%) 1.72s 1.74s
Bind Time 0.66s (± 0.79%) 0.66s (± 0.89%) +0.00s (+ 0.45%) 0.65s 0.68s
Check Time 14.22s (± 0.78%) 14.15s (± 0.46%) -0.06s (- 0.46%) 14.03s 14.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.62s (± 0.69%) 16.55s (± 0.42%) -0.07s (- 0.45%) 16.42s 16.71s
Angular - node (v12.1.0, x64)
Memory used 326,625k (± 0.02%) 326,447k (± 0.08%) -178k (- 0.05%) 325,411k 326,773k
Parse Time 1.80s (± 0.66%) 1.78s (± 0.49%) -0.02s (- 0.83%) 1.76s 1.80s
Bind Time 0.83s (± 1.30%) 0.82s (± 0.72%) -0.01s (- 0.60%) 0.81s 0.84s
Check Time 5.19s (± 0.58%) 5.20s (± 0.62%) +0.00s (+ 0.04%) 5.15s 5.31s
Emit Time 6.07s (± 0.41%) 6.04s (± 0.65%) -0.03s (- 0.54%) 5.98s 6.14s
Total Time 13.89s (± 0.33%) 13.84s (± 0.49%) -0.05s (- 0.38%) 13.70s 14.06s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,734k (± 0.10%) 190,738k (± 0.09%) +4k (+ 0.00%) 190,297k 191,001k
Parse Time 0.78s (± 0.83%) 0.77s (± 0.52%) -0.01s (- 0.90%) 0.76s 0.78s
Bind Time 0.53s (± 0.75%) 0.53s (± 0.84%) +0.00s (+ 0.19%) 0.52s 0.54s
Check Time 7.33s (± 0.47%) 7.30s (± 0.62%) -0.03s (- 0.37%) 7.20s 7.37s
Emit Time 2.45s (± 1.02%) 2.45s (± 0.76%) -0.01s (- 0.24%) 2.41s 2.48s
Total Time 11.09s (± 0.42%) 11.05s (± 0.46%) -0.04s (- 0.32%) 10.92s 11.13s
Monaco - node (v12.1.0, x64)
Memory used 323,695k (± 0.01%) 323,678k (± 0.02%) -17k (- 0.01%) 323,541k 323,891k
Parse Time 1.44s (± 0.70%) 1.42s (± 0.78%) -0.01s (- 0.84%) 1.41s 1.46s
Bind Time 0.73s (± 0.82%) 0.73s (± 0.96%) +0.00s (+ 0.41%) 0.71s 0.74s
Check Time 5.26s (± 0.54%) 5.26s (± 0.70%) +0.00s (+ 0.04%) 5.18s 5.33s
Emit Time 3.20s (± 0.49%) 3.19s (± 0.47%) -0.01s (- 0.34%) 3.16s 3.22s
Total Time 10.62s (± 0.34%) 10.60s (± 0.34%) -0.01s (- 0.14%) 10.54s 10.69s
TFS - node (v12.1.0, x64)
Memory used 288,644k (± 0.03%) 288,560k (± 0.06%) -85k (- 0.03%) 287,853k 288,799k
Parse Time 1.21s (± 0.49%) 1.21s (± 0.61%) -0.00s (- 0.33%) 1.20s 1.23s
Bind Time 0.70s (± 1.27%) 0.69s (± 0.86%) -0.01s (- 1.42%) 0.68s 0.71s
Check Time 4.84s (± 0.44%) 4.80s (± 0.54%) -0.04s (- 0.83%) 4.74s 4.85s
Emit Time 3.38s (± 1.07%) 3.37s (± 0.78%) -0.01s (- 0.21%) 3.33s 3.46s
Total Time 10.13s (± 0.40%) 10.08s (± 0.29%) -0.06s (- 0.55%) 10.02s 10.14s
material-ui - node (v12.1.0, x64)
Memory used 448,401k (± 0.01%) 448,183k (± 0.08%) -218k (- 0.05%) 447,261k 448,547k
Parse Time 1.72s (± 0.52%) 1.72s (± 0.56%) -0.00s (- 0.17%) 1.70s 1.75s
Bind Time 0.66s (± 0.57%) 0.65s (± 0.34%) -0.01s (- 0.92%) 0.64s 0.65s
Check Time 12.86s (± 0.53%) 12.75s (± 0.65%) -0.10s (- 0.80%) 12.60s 12.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.24s (± 0.48%) 15.12s (± 0.58%) -0.12s (- 0.77%) 14.96s 15.33s
Angular - node (v14.15.1, x64)
Memory used 325,716k (± 0.01%) 325,721k (± 0.01%) +5k (+ 0.00%) 325,672k 325,786k
Parse Time 1.82s (± 0.34%) 1.80s (± 0.79%) -0.02s (- 1.10%) 1.78s 1.84s
Bind Time 0.88s (± 0.96%) 0.87s (± 0.77%) -0.01s (- 1.59%) 0.85s 0.88s
Check Time 5.27s (± 0.43%) 5.21s (± 0.38%) -0.06s (- 1.04%) 5.16s 5.27s
Emit Time 6.21s (± 1.05%) 6.14s (± 0.42%) -0.07s (- 1.10%) 6.07s 6.18s
Total Time 14.17s (± 0.53%) 14.02s (± 0.27%) -0.15s (- 1.09%) 13.89s 14.07s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,124k (± 0.63%) 192,095k (± 0.49%) +971k (+ 0.51%) 189,524k 192,797k
Parse Time 0.81s (± 0.83%) 0.81s (± 0.87%) +0.00s (+ 0.25%) 0.80s 0.83s
Bind Time 0.56s (± 0.65%) 0.56s (± 0.40%) -0.00s (- 0.53%) 0.56s 0.57s
Check Time 7.50s (± 0.56%) 7.42s (± 0.63%) -0.08s (- 1.08%) 7.37s 7.60s
Emit Time 2.42s (± 0.73%) 2.41s (± 0.92%) -0.01s (- 0.54%) 2.38s 2.48s
Total Time 11.30s (± 0.47%) 11.20s (± 0.38%) -0.10s (- 0.86%) 11.15s 11.36s
Monaco - node (v14.15.1, x64)
Memory used 322,488k (± 0.01%) 322,478k (± 0.01%) -10k (- 0.00%) 322,434k 322,513k
Parse Time 1.50s (± 0.51%) 1.49s (± 0.86%) -0.01s (- 0.53%) 1.47s 1.53s
Bind Time 0.76s (± 0.59%) 0.75s (± 0.53%) -0.01s (- 1.19%) 0.74s 0.76s
Check Time 5.22s (± 0.50%) 5.17s (± 0.51%) -0.05s (- 0.98%) 5.11s 5.23s
Emit Time 3.24s (± 0.83%) 3.21s (± 0.79%) -0.03s (- 0.90%) 3.17s 3.30s
Total Time 10.71s (± 0.45%) 10.62s (± 0.36%) -0.09s (- 0.87%) 10.57s 10.74s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 287,668k (± 0.01%) +10k (+ 0.00%) 287,630k 287,700k
Parse Time 1.23s (± 1.43%) 1.24s (± 1.25%) +0.01s (+ 0.73%) 1.20s 1.26s
Bind Time 0.75s (± 3.33%) 0.73s (± 3.43%) -0.02s (- 2.28%) 0.71s 0.83s
Check Time 4.82s (± 0.43%) 4.81s (± 0.35%) -0.00s (- 0.06%) 4.79s 4.86s
Emit Time 3.45s (± 0.74%) 3.46s (± 0.85%) +0.02s (+ 0.46%) 3.40s 3.53s
Total Time 10.24s (± 0.36%) 10.25s (± 0.33%) +0.00s (+ 0.05%) 10.17s 10.31s
material-ui - node (v14.15.1, x64)
Memory used 446,859k (± 0.00%) 446,617k (± 0.07%) -242k (- 0.05%) 445,786k 446,865k
Parse Time 1.76s (± 0.46%) 1.75s (± 0.39%) -0.01s (- 0.51%) 1.75s 1.78s
Bind Time 0.69s (± 0.68%) 0.69s (± 0.75%) +0.00s (+ 0.14%) 0.68s 0.70s
Check Time 13.00s (± 0.88%) 12.90s (± 0.92%) -0.10s (- 0.75%) 12.77s 13.25s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.45s (± 0.76%) 15.34s (± 0.76%) -0.10s (- 0.67%) 15.21s 15.70s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 45148 10
Baseline main 10

Developer Information:

Download Benchmark

@ahejlsberg
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at 42f4554. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..45148

Metric main 45148 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 348,498k (± 0.03%) 348,499k (± 0.03%) +2k (+ 0.00%) 348,219k 348,735k
Parse Time 1.81s (± 0.57%) 1.80s (± 0.53%) -0.01s (- 0.44%) 1.78s 1.83s
Bind Time 0.84s (± 0.90%) 0.85s (± 0.76%) +0.00s (+ 0.47%) 0.83s 0.86s
Check Time 5.37s (± 0.72%) 5.35s (± 0.66%) -0.02s (- 0.34%) 5.26s 5.42s
Emit Time 5.85s (± 0.54%) 5.82s (± 0.66%) -0.03s (- 0.55%) 5.71s 5.90s
Total Time 13.88s (± 0.47%) 13.82s (± 0.54%) -0.06s (- 0.40%) 13.59s 13.97s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,376k (± 0.02%) 203,107k (± 0.28%) -269k (- 0.13%) 200,805k 203,508k
Parse Time 0.78s (± 0.95%) 0.78s (± 0.79%) -0.00s (- 0.26%) 0.77s 0.79s
Bind Time 0.53s (± 1.27%) 0.52s (± 1.45%) -0.00s (- 0.57%) 0.50s 0.54s
Check Time 7.83s (± 0.69%) 7.82s (± 0.48%) -0.01s (- 0.10%) 7.77s 7.93s
Emit Time 2.43s (± 0.51%) 2.44s (± 0.73%) +0.01s (+ 0.58%) 2.41s 2.48s
Total Time 11.56s (± 0.51%) 11.56s (± 0.44%) -0.00s (- 0.01%) 11.48s 11.69s
Monaco - node (v10.16.3, x64)
Memory used 340,535k (± 0.03%) 340,556k (± 0.03%) +21k (+ 0.01%) 340,375k 340,762k
Parse Time 1.47s (± 1.01%) 1.46s (± 0.57%) -0.01s (- 0.95%) 1.43s 1.47s
Bind Time 0.75s (± 0.97%) 0.75s (± 0.60%) 0.00s ( 0.00%) 0.74s 0.76s
Check Time 5.38s (± 0.74%) 5.36s (± 0.62%) -0.02s (- 0.45%) 5.27s 5.41s
Emit Time 3.16s (± 0.86%) 3.17s (± 1.49%) +0.00s (+ 0.16%) 3.08s 3.31s
Total Time 10.76s (± 0.37%) 10.73s (± 0.34%) -0.03s (- 0.26%) 10.66s 10.80s
TFS - node (v10.16.3, x64)
Memory used 304,022k (± 0.02%) 304,000k (± 0.02%) -22k (- 0.01%) 303,852k 304,176k
Parse Time 1.19s (± 0.52%) 1.19s (± 0.50%) +0.01s (+ 0.50%) 1.18s 1.21s
Bind Time 0.71s (± 0.70%) 0.72s (± 0.69%) +0.00s (+ 0.14%) 0.71s 0.73s
Check Time 4.90s (± 0.40%) 4.91s (± 0.50%) +0.01s (+ 0.12%) 4.86s 4.97s
Emit Time 3.32s (± 0.79%) 3.33s (± 1.30%) +0.00s (+ 0.12%) 3.23s 3.42s
Total Time 10.12s (± 0.34%) 10.14s (± 0.58%) +0.02s (+ 0.22%) 10.00s 10.31s
material-ui - node (v10.16.3, x64)
Memory used 469,690k (± 0.01%) 469,680k (± 0.01%) -11k (- 0.00%) 469,544k 469,801k
Parse Time 1.74s (± 0.57%) 1.73s (± 0.27%) -0.01s (- 0.57%) 1.72s 1.74s
Bind Time 0.66s (± 0.79%) 0.67s (± 1.16%) +0.01s (+ 1.21%) 0.65s 0.69s
Check Time 14.22s (± 0.78%) 14.25s (± 0.63%) +0.03s (+ 0.21%) 14.05s 14.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.62s (± 0.69%) 16.64s (± 0.53%) +0.02s (+ 0.14%) 16.44s 16.81s
Angular - node (v12.1.0, x64)
Memory used 326,625k (± 0.02%) 326,582k (± 0.03%) -43k (- 0.01%) 326,426k 326,818k
Parse Time 1.80s (± 0.66%) 1.79s (± 0.87%) -0.01s (- 0.33%) 1.77s 1.84s
Bind Time 0.83s (± 1.30%) 0.83s (± 0.97%) -0.00s (- 0.12%) 0.81s 0.85s
Check Time 5.19s (± 0.58%) 5.20s (± 0.35%) +0.00s (+ 0.08%) 5.16s 5.23s
Emit Time 6.07s (± 0.41%) 6.04s (± 0.62%) -0.03s (- 0.53%) 5.94s 6.11s
Total Time 13.89s (± 0.33%) 13.85s (± 0.33%) -0.04s (- 0.29%) 13.72s 13.93s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,734k (± 0.10%) 190,785k (± 0.09%) +51k (+ 0.03%) 190,200k 190,986k
Parse Time 0.78s (± 0.83%) 0.78s (± 0.98%) -0.00s (- 0.39%) 0.75s 0.79s
Bind Time 0.53s (± 0.75%) 0.53s (± 0.89%) +0.00s (+ 0.38%) 0.52s 0.54s
Check Time 7.33s (± 0.47%) 7.31s (± 0.87%) -0.02s (- 0.20%) 7.12s 7.41s
Emit Time 2.45s (± 1.02%) 2.40s (± 1.63%) -0.05s (- 2.04%) 2.26s 2.46s
Total Time 11.09s (± 0.42%) 11.02s (± 0.93%) -0.06s (- 0.57%) 10.65s 11.16s
Monaco - node (v12.1.0, x64)
Memory used 323,695k (± 0.01%) 323,703k (± 0.02%) +7k (+ 0.00%) 323,545k 323,871k
Parse Time 1.44s (± 0.70%) 1.43s (± 0.54%) -0.01s (- 0.49%) 1.41s 1.44s
Bind Time 0.73s (± 0.82%) 0.73s (± 1.04%) +0.00s (+ 0.00%) 0.71s 0.75s
Check Time 5.26s (± 0.54%) 5.25s (± 0.56%) -0.01s (- 0.19%) 5.19s 5.30s
Emit Time 3.20s (± 0.49%) 3.18s (± 0.55%) -0.02s (- 0.59%) 3.13s 3.21s
Total Time 10.62s (± 0.34%) 10.58s (± 0.44%) -0.04s (- 0.35%) 10.47s 10.66s
TFS - node (v12.1.0, x64)
Memory used 288,644k (± 0.03%) 288,651k (± 0.02%) +7k (+ 0.00%) 288,536k 288,778k
Parse Time 1.21s (± 0.49%) 1.21s (± 0.66%) -0.01s (- 0.49%) 1.19s 1.22s
Bind Time 0.70s (± 1.27%) 0.70s (± 0.64%) -0.01s (- 0.99%) 0.69s 0.71s
Check Time 4.84s (± 0.44%) 4.82s (± 0.40%) -0.02s (- 0.33%) 4.78s 4.87s
Emit Time 3.38s (± 1.07%) 3.38s (± 0.89%) +0.00s (+ 0.03%) 3.28s 3.43s
Total Time 10.13s (± 0.40%) 10.11s (± 0.40%) -0.03s (- 0.27%) 9.98s 10.18s
material-ui - node (v12.1.0, x64)
Memory used 448,401k (± 0.01%) 448,239k (± 0.07%) -162k (- 0.04%) 447,285k 448,504k
Parse Time 1.72s (± 0.52%) 1.72s (± 0.58%) 0.00s ( 0.00%) 1.71s 1.76s
Bind Time 0.66s (± 0.57%) 0.66s (± 0.76%) 0.00s ( 0.00%) 0.65s 0.67s
Check Time 12.86s (± 0.53%) 12.79s (± 1.01%) -0.06s (- 0.48%) 12.63s 13.16s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.24s (± 0.48%) 15.17s (± 0.84%) -0.07s (- 0.43%) 15.00s 15.54s
Angular - node (v14.15.1, x64)
Memory used 325,716k (± 0.01%) 325,714k (± 0.01%) -1k (- 0.00%) 325,676k 325,747k
Parse Time 1.82s (± 0.34%) 1.81s (± 0.80%) -0.00s (- 0.22%) 1.79s 1.86s
Bind Time 0.88s (± 0.96%) 0.87s (± 0.54%) -0.01s (- 1.25%) 0.86s 0.88s
Check Time 5.27s (± 0.43%) 5.23s (± 0.42%) -0.04s (- 0.76%) 5.19s 5.31s
Emit Time 6.21s (± 1.05%) 6.14s (± 0.41%) -0.07s (- 1.08%) 6.07s 6.18s
Total Time 14.17s (± 0.53%) 14.05s (± 0.28%) -0.12s (- 0.87%) 13.98s 14.18s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,124k (± 0.63%) 190,799k (± 0.61%) -325k (- 0.17%) 189,462k 192,767k
Parse Time 0.81s (± 0.83%) 0.81s (± 0.49%) +0.00s (+ 0.25%) 0.80s 0.82s
Bind Time 0.56s (± 0.65%) 0.56s (± 0.71%) -0.00s (- 0.53%) 0.55s 0.57s
Check Time 7.50s (± 0.56%) 7.48s (± 0.71%) -0.02s (- 0.31%) 7.42s 7.68s
Emit Time 2.42s (± 0.73%) 2.43s (± 0.60%) +0.01s (+ 0.29%) 2.38s 2.46s
Total Time 11.30s (± 0.47%) 11.28s (± 0.46%) -0.02s (- 0.18%) 11.21s 11.47s
Monaco - node (v14.15.1, x64)
Memory used 322,488k (± 0.01%) 322,487k (± 0.00%) -1k (- 0.00%) 322,462k 322,518k
Parse Time 1.50s (± 0.51%) 1.48s (± 0.50%) -0.02s (- 1.07%) 1.47s 1.50s
Bind Time 0.76s (± 0.59%) 0.75s (± 0.74%) -0.01s (- 0.79%) 0.74s 0.76s
Check Time 5.22s (± 0.50%) 5.18s (± 0.40%) -0.04s (- 0.80%) 5.15s 5.25s
Emit Time 3.24s (± 0.83%) 3.22s (± 0.68%) -0.02s (- 0.74%) 3.17s 3.27s
Total Time 10.71s (± 0.45%) 10.63s (± 0.19%) -0.08s (- 0.75%) 10.59s 10.67s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 287,680k (± 0.01%) +23k (+ 0.01%) 287,649k 287,724k
Parse Time 1.23s (± 1.43%) 1.25s (± 2.36%) +0.02s (+ 1.62%) 1.21s 1.33s
Bind Time 0.75s (± 3.33%) 0.74s (± 4.12%) -0.00s (- 0.27%) 0.71s 0.83s
Check Time 4.82s (± 0.43%) 4.82s (± 0.45%) +0.01s (+ 0.10%) 4.77s 4.88s
Emit Time 3.45s (± 0.74%) 3.47s (± 0.63%) +0.02s (+ 0.58%) 3.41s 3.52s
Total Time 10.24s (± 0.36%) 10.28s (± 0.53%) +0.04s (+ 0.40%) 10.16s 10.38s
material-ui - node (v14.15.1, x64)
Memory used 446,859k (± 0.00%) 446,847k (± 0.01%) -12k (- 0.00%) 446,764k 446,903k
Parse Time 1.76s (± 0.46%) 1.76s (± 0.52%) -0.00s (- 0.23%) 1.74s 1.78s
Bind Time 0.69s (± 0.68%) 0.68s (± 0.53%) -0.01s (- 0.87%) 0.68s 0.69s
Check Time 13.00s (± 0.88%) 12.93s (± 0.52%) -0.07s (- 0.51%) 12.77s 13.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.45s (± 0.76%) 15.37s (± 0.43%) -0.08s (- 0.49%) 15.24s 15.54s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 45148 10
Baseline main 10

Developer Information:

Download Benchmark

@ahejlsberg
Copy link
Member Author

Tests all look good, ever so slight performance gain because we now use isGenericType and compute both flags together.

@ahejlsberg ahejlsberg merged commit 3bd5079 into main Aug 6, 2021
@ahejlsberg ahejlsberg deleted the fix45145 branch August 6, 2021 06:53
BobobUnicorn pushed a commit to BobobUnicorn/TypeScript that referenced this pull request Oct 24, 2021
@ahejlsberg @BobobUnicorn
Fix check for generic types in control flow analysis (microsoft#45148)
00f4aac 
* Fix check in hasNonBindingPatternContextualTypeWithNoGenericTypes

* Add regression tests

* Accept new baselines

* Compute both ObjectFlags.IsGenericXXXType flags in one go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type not assignable to its own Partial
3 participants
@ahejlsberg @typescript-bot @sandersn