Skip to content

fix(45233): export default can not be typed via jsdoc #45342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #45233

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 6, 2021
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way the code looks now, although one of the type baselines is wrong.

@a-tarasyuk a-tarasyuk force-pushed the fix/45233 branch 2 times, most recently from 39741aa to db74fad Compare August 12, 2021 16:09
@a-tarasyuk a-tarasyuk requested a review from sandersn August 12, 2021 18:38
@sandersn sandersn merged commit 5b3072f into microsoft:main Aug 13, 2021
BobobUnicorn pushed a commit to BobobUnicorn/TypeScript that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export default can not be typed via jsdoc
3 participants