Skip to content

Removed lookahead for simple arrow function expressions. #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2014

Conversation

ahejlsberg
Copy link
Member

The parser currently performs a look-ahead on every expression that starts with an identifier to determine if an => token follows. This commit reverts back to the original design of recognizing an expression consisting of a single identifier to the left of an => token and then treating that identifier as a parameter list. This reduces the overall number of look-aheads performed by the scanner by over 30%.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 15, 2014

👍

2 similar comments
@sheetalkamat
Copy link
Member

👍

@vladima
Copy link
Contributor

vladima commented Aug 15, 2014

👍

ahejlsberg added a commit that referenced this pull request Aug 15, 2014
Removed lookahead for simple arrow function expressions.
@ahejlsberg ahejlsberg merged commit eea8409 into master Aug 15, 2014
@ahejlsberg ahejlsberg deleted the noArrowLookahead branch August 15, 2014 19:54
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants