-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Remove defaultValueDescription: "n/a" from options #46280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
src/compiler/types.ts
Outdated
/* @internal */ | ||
export interface CommandLineOptionOfBooleanType extends CommandLineOptionBase { | ||
type: "boolean"; | ||
defaultValueDescription?: "true" | "false" | "undefined" | DiagnosticMessage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what do you think about refining the CommandLineOption
type like so, to check .type
<-> .defaultValueDescription
agreement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this seems reasonable to me - it doesn't look like a breaking change, but would be nice to have at least one other person take a look over it.
Switching from n/a
is good simply because n/a
is a tad ambiguous anyway.
* Remove defaultValueDescription: "n/a" from options * CommandLineOption type <-> defaultValueDescription * Require defaultValueDescription of number/boolean options
Are there different meanings to
defaultValueDescription: "n/a"
and omittingdefaultValueDescription
?/cc @orta