Fix mapped type instantiation circularity #46586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
@typescript-bot run dt |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 7dc887f. You can monitor the build here. |
sandersn
approved these changes
Oct 29, 2021
Comment on lines
+16575
to
+16576
| if (isArrayType(t) || t.flags & TypeFlags.Any && findResolutionCycleStartIndex(typeVariable, TypeSystemPropertyName.ImmediateBaseConstraint) < 0 && | ||
| (constraint = getConstraintOfTypeParameter(typeVariable)) && everyType(constraint, or(isArrayType, isTupleType))) { |
There was a problem hiding this comment.
One day, we should find an easy/reusable way to easily ask "is this true *assuming that there are no circularities?"
Today is not that day.
DanielRosenwasser
approved these changes
Oct 29, 2021
DanielRosenwasser
requested changes
Oct 29, 2021
Comment on lines
58
to
64
| export type Evolvable<E extends Evolver> = { | ||
| [P in keyof E]: never; | ||
| }; | ||
| export type Evolver<T extends Evolvable<any> = any> = { | ||
| [key in keyof Partial<T>]: never; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Can you remove the export here, or make all of the types exported? This turned off .d.ts emit for the rest of the file.
|
DT tests look good, error in |
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Don't obtain constraint if doing so would cause circularity * Add regression test * Address CR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46582.