support quickinfo and go-to-definition on typeof this
#47085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm extremely worried about the perf implications of this... Update: wrong! @typescript-bot perf test this |
|
Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at 134d561. You can monitor the build here. Update: The results are in! |
|
@RyanCavanaugh Here they are:Comparison Report - main..47085
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
And this happens to fix a symbol accessibility issue: class Test13 {
num = 0;
// Parameter 'num' of public method from exported class has or is using private name 'this'.
test1(num: typeof this.num = this.num) {
}
} |
sandersn
requested changes
Jan 14, 2022
src/compiler/checker.ts
Outdated
| @@ -34018,7 +34018,7 @@ namespace ts { | |||
| } | |||
| switch (kind) { | |||
| case SyntaxKind.Identifier: | |||
| return checkIdentifier(node as Identifier, checkMode); | |||
| return isThisInTypeQuery(node) ? checkThisExpression(node) : checkIdentifier(node as Identifier, checkMode); | |||
There was a problem hiding this comment.
fairly minor style request: move this check into the top of checkIdentifier. It's only called from here, and it keeps checkExpressionWorker as simple as possible.
(Looking at the rest of checkExpressionWorker, the only exception I see is BigIntLiteral, which just has the inline source of what should be checkBigIntLiteral.)
| @@ -41,7 +41,7 @@ namespace ts.SymbolDisplay { | |||
| if (typeChecker.isArgumentsSymbol(symbol)) { | |||
| return ScriptElementKind.localVariableElement; | |||
| } | |||
| if (location.kind === SyntaxKind.ThisKeyword && isExpression(location)) { | |||
| if (location.kind === SyntaxKind.ThisKeyword && isExpression(location) || isThisInTypeQuery(location)) { | |||
There was a problem hiding this comment.
This is probably out of scope for this review, but it would be nice for these two checks to use the same code (not isExpression vs isExpressionContext), and then be extracted to a function.
|
@RyanCavanaugh this change looks scary because it changes checkExpressionWorker but really all it does is check the type of |
sandersn
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47063