Merge InlayHintOptions into UserPreferences
#47729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
Feb 3, 2022
sandersn
approved these changes
Feb 5, 2022
|
I'm going to merge this since main is open for 4.7 PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions related to inlay hints expected a parameter of type
InlayHintOptions, which extendedUserPreferences. But they are called with aUserPreferencesargument (from the preferences we store on aSession/ProjectService). So the inlay hints options should be part ofUserPreferences, since it's no longer only an experimental feature.This is technically a breaking API change, since it removes the
InlayHintOptionsinterface.