Fix getExportSymbolOfValueSymbolIfExported
#48769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
Apr 19, 2022
| @@ -4109,7 +4109,7 @@ namespace ts { | |||
| function getExportSymbolOfValueSymbolIfExported(symbol: Symbol): Symbol; | |||
| function getExportSymbolOfValueSymbolIfExported(symbol: Symbol | undefined): Symbol | undefined; | |||
| function getExportSymbolOfValueSymbolIfExported(symbol: Symbol | undefined): Symbol | undefined { | |||
| return getMergedSymbol(symbol && (symbol.flags & SymbolFlags.ExportValue) !== 0 ? symbol.exportSymbol : symbol); | |||
| return getMergedSymbol(symbol && (symbol.flags & SymbolFlags.ExportValue) !== 0 && symbol.exportSymbol || symbol); | |||
There was a problem hiding this comment.
The symbol passed here that had the ExportValue flag but no exportSymbol was the export= symbol for constants.js in the test case.
There was a problem hiding this comment.
The export= symbol is the result of a symbol merge, afaik - is it as simple as cloneSymbol not copying this field when it should?
There was a problem hiding this comment.
This export= symbol is not a merged symbol, no.
weswigham
approved these changes
Apr 20, 2022
raghavthind2005
approved these changes
Apr 26, 2022
sandersn
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function assumes that
SymbolFlags.ExportValueimpliessymbol.exportSymbol, but that doesn’t always hold. Looking through the binder, it seems more likely that this function is wrong than all the places in the binder that applyExportValuewithout declaring anexportSymbolare wrong, but maybe @sandersn knows more about this.Fixes #48655
Fixes #48322