Skip to content

Use symbolic GitHub Actions Node.js versions #49403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/accept-baselines-fix-lints.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use node version 14
uses: actions/setup-node@v3
with:
node-version: 14
registry-url: https://registry.npmjs.org/
- uses: actions/setup-node@v3

- name: Configure Git, Run Tests, Update Baselines, Apply Fixes
run: |
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
# Test the latest version of Node.js plus the last two LTS versions.
node-version:
- "*"
- lts/*
- lts/-1

steps:
- uses: actions/checkout@v3
Expand All @@ -26,6 +30,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
check-latest: true
- name: Remove existing TypeScript
run: |
npm uninstall typescript --no-save
Expand All @@ -47,4 +52,3 @@ jobs:

- name: Validate the browser can import TypeScript
run: gulp test-browser-integration

5 changes: 1 addition & 4 deletions .github/workflows/new-release-branch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Use node version 14.x
uses: actions/setup-node@v3
with:
node-version: 14.x
- uses: actions/setup-node@v3
- uses: actions/checkout@v2
with:
fetch-depth: 5
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use node version 14
uses: actions/setup-node@v3
with:
node-version: 14
registry-url: https://registry.npmjs.org/
- uses: actions/setup-node@v3
- name: Setup and publish nightly
run: |
npm whoami
Expand All @@ -30,6 +26,4 @@ jobs:
gulp clean
npm publish --tag next
env:
NODE_AUTH_TOKEN: ${{secrets.npm_token}}
CI: true

NPM_TOKEN: ${{secrets.npm_token}}
11 changes: 2 additions & 9 deletions .github/workflows/release-branch-artifact.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use node version 14
uses: actions/setup-node@v3
with:
node-version: 14
- uses: actions/setup-node@v3
- name: Remove existing TypeScript
run: |
npm uninstall typescript --no-save
Expand All @@ -23,10 +20,8 @@ jobs:
run: |
npm ci
npm test
env:
CI: true
- name: Adding playwright
run: npm install --no-save --no-package-lock playwright
run: npm install --no-save --no-package-lock playwright
- name: Validate the browser can import TypeScript
run: gulp test-browser-integration
- name: LKG, clean, and pack
Expand All @@ -35,8 +30,6 @@ jobs:
gulp clean
npm pack ./
mv typescript-*.tgz typescript.tgz
env:
CI: true
- name: Upload built tarfile
uses: actions/upload-artifact@v1
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/rich-navigation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ jobs:
fetch-depth: 5

- uses: actions/setup-node@v3
with:
node-version: 14

- name: Install dependencies
run: npm ci
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/set-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Use node version 14.x
uses: actions/setup-node@v3
with:
node-version: 14.x
- uses: actions/setup-node@v3
- uses: actions/checkout@v2
with:
ref: ${{ github.event.client_payload.branch_name }}
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/sync-branch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Use node version 14.x
uses: actions/setup-node@v3
with:
node-version: 14.x
- uses: actions/setup-node@v3
- uses: actions/checkout@v2
with:
ref: ${{ github.event.inputs.branch_name || github.event.client_payload.branch_name }}
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/twoslash-repros.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@ jobs:
if: ${{ github.repository == 'microsoft/TypeScript' && !github.event.label && !github.event.inputs.bisect_issue }}
runs-on: ubuntu-latest
steps:
- name: Use node
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
- uses: microsoft/TypeScript-Twoslash-Repro-Action@master
with:
with:
github-token: ${{ secrets.TS_BOT_GITHUB_TOKEN }}

bisect:
if: ${{ github.event.label.name == 'Bisect Repro' || github.event.inputs.bisect_issue }}
runs-on: ubuntu-latest
Expand All @@ -37,9 +36,7 @@ jobs:
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
- uses: microsoft/TypeScript-Twoslash-Repro-Action@master
with:
with:
github-token: ${{ secrets.TS_BOT_GITHUB_TOKEN }}
bisect: ${{ github.event.issue.number || github.event.inputs.bisect_issue }}
6 changes: 1 addition & 5 deletions .github/workflows/update-lkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use node version 14
uses: actions/setup-node@v3
with:
node-version: 14
registry-url: https://registry.npmjs.org/
- uses: actions/setup-node@v3

- name: Configure Git and Update LKG
run: |
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/update-package-lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14
registry-url: https://registry.npmjs.org/

- name: Configure git and update package-lock.json
run: |
Expand Down