Create special --no-typecheck script #51830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that if you have a task set up on vscode (on
tasks.json) whose script string has spaces in it, e.g."script": "build:tests -- --no-typecheck", then on WSL vscode adds quotes around the script string when it runs the task, meaning that for ournpm: build:teststask, vscode ran the commandnpm run "build:tests -- --no-typecheck", which thenpm runcommand doesn't recognize. This was getting in the way of using our preconfigured test debug setting on vscode on WSL, so I created a separate npm build tests script that adds the--no-typecheckflag to its invocation directly.