Skip to content

Add a test for optional members completions within an object within an index signature constraint #52149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Jan 8, 2023

closes #9900

this is a test case from #9900 where the issue was fixed by #34855 . Since the fixing PR didn't include a test like this, I decided to PR this one, cc @andrewbranch

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 8, 2023
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewbranch andrewbranch merged commit f326cbf into microsoft:main Jan 9, 2023
@Andarist Andarist deleted the tests/completions-index-signature-constraint branch January 9, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS losing optional properties when used with index signature and generics
3 participants