Shorten loc messages #5273
Merged
Shorten loc messages #5273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? localizedDiagnosticMessages[message] | ||
| : message; | ||
| export function getLocaleSpecificMessage(message: DiagnosticMessage) { | ||
| return localizedDiagnosticMessages && localizedDiagnosticMessages[message.key] |
There was a problem hiding this comment.
For an empty string key, you'll always use the non-localized message unless you use message.key in localizedDiagnosticMessages. Though, that would be the most ridiculous edge case I may have ever brought up.
|
👍 |
| @@ -18,6 +18,13 @@ function main(): void { | |||
| return; | |||
| } | |||
|
|
|||
| function writeFile(fileName: string, contents: string) { | |||
| // TODO: Fix path joining | |||
There was a problem hiding this comment.
why this is a TODO instead of fixing it in the PR
There was a problem hiding this comment.
because it works ... not sure what @DanielRosenwasser Daniel meant here
There was a problem hiding this comment.
|
@paulvanbrenk and @DanielRosenwasser is this ready? |
|
@mhegazy testing and I needed to finish setting up loc support before I could actually check this in. EOD tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.