Skip to content

pre-initialize Node fields in constructor #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2015
Merged

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Oct 21, 2015

No description provided.

@@ -797,13 +797,13 @@ namespace ts {
export let objectAllocator: ObjectAllocator = {
getNodeConstructor: kind => {
function Node() {
this.pos = -1;
this.end = -1;
this.flags = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeFlags.None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have this one

@mhegazy
Copy link
Contributor

mhegazy commented Oct 21, 2015

👍

vladima added a commit that referenced this pull request Oct 21, 2015
pre-initialize Node fields in constructor
@vladima vladima merged commit 9afc2b3 into master Oct 21, 2015
@vladima vladima deleted the initFieldsInConstructor branch October 21, 2015 23:07
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants