cache results of fileExists check in default compiler host #5367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this a problem for |
|
it might. Also we currently already cache results of |
|
|
|
directory can be deleted between recompilations and we still will think it exists |
|
You could also make a helper function for |
| @@ -286,6 +295,13 @@ namespace ts { | |||
| reportWatchDiagnostic(createCompilerDiagnostic(Diagnostics.Compilation_complete_Watching_for_file_changes)); | |||
| } | |||
|
|
|||
| function fileExists(fileName: string): boolean { | |||
There was a problem hiding this comment.
can we rename this to cachedFileExist just to make it clear.
|
👍 |
vladima
added a commit
that referenced
this pull request
Oct 23, 2015
cache results of fileExists check in default compiler host
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.