Use dedicated type to store paths #5462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2183,6 +2182,12 @@ namespace ts { | |||
| return result; | |||
| } | |||
|
|
|||
| export function toRelativePath(absoluteOrRelativePath: string, basePath: string, getCanonicalFileName: (path: string) => string): string { | |||
There was a problem hiding this comment.
nit. other helpers have a verb to begin them, like convert, get.. etc..
|
👍 |
vladima
added a commit
that referenced
this pull request
Oct 30, 2015
…ingImports Use dedicated type to store paths
|
👏 👏 👏 |
This was referenced Nov 3, 2015
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Pathtype to store normalized, canonicalized absolute paths. Currently we use plain strings and we have to conservatively normalize them every time we want to use them as key in map. WithPathwe can usetoPathfunction to convert string to path and then rely on type system to prevent incorrect usages.Also this PR partially reverts effect from #5275 - now we don't convert resolved module name to relative when we retrieve source file from the host. As a consequence of this now source files in program can have mixed styled file names (absolute and relative). In order to unpleasant user experience when file names in error messages have different representation we convert all file names to relative before printing them