-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Copyright comments are not preserved when generating d.ts files #5472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
tests/baselines/reference/declarationEmitDetachedComment1.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| //// [tests/cases/compiler/declarationEmitDetachedComment1.ts] //// | ||
|
|
||
| //// [test1.ts] | ||
|
|
||
| /*! Copyright 2015 MyCompany Inc. */ | ||
|
|
||
| /** | ||
| * Hello class | ||
| */ | ||
| class Hello { | ||
|
|
||
| } | ||
|
|
||
| //// [test2.ts] | ||
| /* A comment at the top of the file. */ | ||
|
|
||
| /** | ||
| * Hi class | ||
| */ | ||
| class Hi { | ||
|
|
||
| } | ||
|
|
||
| //// [test3.ts] | ||
| // A one-line comment at the top of the file. | ||
|
|
||
| /** | ||
| * Hola class | ||
| */ | ||
| class Hola { | ||
|
|
||
| } | ||
|
|
||
|
|
||
| //// [test1.js] | ||
| /*! Copyright 2015 MyCompany Inc. */ | ||
| /** | ||
| * Hello class | ||
| */ | ||
| var Hello = (function () { | ||
| function Hello() { | ||
| } | ||
| return Hello; | ||
| })(); | ||
| //// [test2.js] | ||
| /* A comment at the top of the file. */ | ||
| /** | ||
| * Hi class | ||
| */ | ||
| var Hi = (function () { | ||
| function Hi() { | ||
| } | ||
| return Hi; | ||
| })(); | ||
| //// [test3.js] | ||
| // A one-line comment at the top of the file. | ||
| /** | ||
| * Hola class | ||
| */ | ||
| var Hola = (function () { | ||
| function Hola() { | ||
| } | ||
| return Hola; | ||
| })(); | ||
|
|
||
|
|
||
| //// [test1.d.ts] | ||
| /*! Copyright 2015 MyCompany Inc. */ | ||
| /** | ||
| * Hello class | ||
| */ | ||
| declare class Hello { | ||
| } | ||
| //// [test2.d.ts] | ||
| /** | ||
| * Hi class | ||
| */ | ||
| declare class Hi { | ||
| } | ||
| //// [test3.d.ts] | ||
| /** | ||
| * Hola class | ||
| */ | ||
| declare class Hola { | ||
| } |
34 changes: 34 additions & 0 deletions
34
tests/baselines/reference/declarationEmitDetachedComment1.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| === tests/cases/compiler/test1.ts === | ||
|
|
||
| /*! Copyright 2015 MyCompany Inc. */ | ||
|
|
||
| /** | ||
| * Hello class | ||
| */ | ||
| class Hello { | ||
| >Hello : Symbol(Hello, Decl(test1.ts, 0, 0)) | ||
|
|
||
| } | ||
|
|
||
| === tests/cases/compiler/test2.ts === | ||
| /* A comment at the top of the file. */ | ||
|
|
||
| /** | ||
| * Hi class | ||
| */ | ||
| class Hi { | ||
| >Hi : Symbol(Hi, Decl(test2.ts, 0, 0)) | ||
|
|
||
| } | ||
|
|
||
| === tests/cases/compiler/test3.ts === | ||
| // A one-line comment at the top of the file. | ||
|
|
||
| /** | ||
| * Hola class | ||
| */ | ||
| class Hola { | ||
| >Hola : Symbol(Hola, Decl(test3.ts, 0, 0)) | ||
|
|
||
| } | ||
|
|
34 changes: 34 additions & 0 deletions
34
tests/baselines/reference/declarationEmitDetachedComment1.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| === tests/cases/compiler/test1.ts === | ||
|
|
||
| /*! Copyright 2015 MyCompany Inc. */ | ||
|
|
||
| /** | ||
| * Hello class | ||
| */ | ||
| class Hello { | ||
| >Hello : Hello | ||
|
|
||
| } | ||
|
|
||
| === tests/cases/compiler/test2.ts === | ||
| /* A comment at the top of the file. */ | ||
|
|
||
| /** | ||
| * Hi class | ||
| */ | ||
| class Hi { | ||
| >Hi : Hi | ||
|
|
||
| } | ||
|
|
||
| === tests/cases/compiler/test3.ts === | ||
| // A one-line comment at the top of the file. | ||
|
|
||
| /** | ||
| * Hola class | ||
| */ | ||
| class Hola { | ||
| >Hola : Hola | ||
|
|
||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick JSDoc comment would be helpful here.