Report circular type inference errors with -noImplicitAny #665
Conversation
|
I should add that if we implement #647 the errors reported with -noImplicitAny for circular uses of |
| "Function implicitly has return type 'any' because type inference encountered a circularity.": { | ||
| "category": "Error", | ||
| "code": 7023 | ||
| }, |
There was a problem hiding this comment.
Can we make the error message a bit more explicit. I do not find "circularity" particularly helpful, specially that we do not print the cycle. how about:
'{0}' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its initializer.
Function implicitly has return type 'any' because it does not have a return type annotation and it is referenced directly or indirectly in at least one if its return expressions.
There was a problem hiding this comment.
Agreed. I will change the error messages.
|
I find the error message un-actionable, but other than that looks good to me. thanks. |
|
👍 |
Report circular type inference errors with -noImplicitAny
Fixes #476.