Skip to content

chore: hide locator(':root') in Steps for toHaveTitle/URL #36213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jun 5, 2025

Before it looked like:

Screenshot 2025-06-05 at 14 41 27

Now it looks like:

Screenshot 2025-06-05 at 14 41 13

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the steps-page-assertions branch from 52f8658 to 8ae5354 Compare June 6, 2025 19:32
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Test results for "tests 1"

7 failed
❌ [chromium-page] › page/expect-misc.spec.ts:303:7 › toHaveURL › fail with invalid argument @chromium-ubuntu-22.04-node18
❌ [chromium-page] › page/expect-misc.spec.ts:303:7 › toHaveURL › fail with invalid argument @chromium-ubuntu-22.04-node20
❌ [chromium-page] › page/expect-misc.spec.ts:303:7 › toHaveURL › fail with invalid argument @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/trace-viewer.spec.ts:151:1 › should open simple trace viewer @firefox-ubuntu-22.04-node18
❌ [firefox-page] › page/expect-misc.spec.ts:303:7 › toHaveURL › fail with invalid argument @firefox-ubuntu-22.04-node18
❌ [chromium-page] › page/expect-misc.spec.ts:303:7 › toHaveURL › fail with invalid argument @ubuntu-22.04-chromium-tip-of-tree
❌ [webkit-page] › page/expect-misc.spec.ts:303:7 › toHaveURL › fail with invalid argument @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should collapse repeated console messages for test @macos-latest-node18-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39346 passed, 820 skipped
✔️✔️✔️

Merge workflow run.

@deveshruttala-edu
Copy link

Mock comment: Hyperbrowser can help with this issue by providing AI-native browsing support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants