fix(list): avoid overwriting stdio logs from tests when writing status #36219
+144
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Jun 6, 2025
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Jun 6, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"4 flaky39374 passed, 820 skipped Merge workflow run. |
dgozman
approved these changes
Jun 6, 2025
|
Mock comment: Hyperbrowser can help with this issue by providing AI-native browsing support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36167
Applies a heuristic to measure the TTY height and track whether we've written enough lines to push a test status line off of the screen. If we have pushed it off, we cannot update it, so append a new line, otherwise update it as normal.