Skip to content

chore: make expect throw an error with details instead of returning them #36232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 6, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Test results for "tests 1"

12 failed
❌ [chromium-library] › library/trace-viewer.spec.ts:960:1 › should highlight expect failure @chromium-ubuntu-22.04-node18
❌ [chromium-page] › page/expect-timeout.spec.ts:45:5 › should not print timed out error message when page closes @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/trace-viewer.spec.ts:960:1 › should highlight expect failure @chromium-ubuntu-22.04-node20
❌ [chromium-page] › page/expect-timeout.spec.ts:45:5 › should not print timed out error message when page closes @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/trace-viewer.spec.ts:960:1 › should highlight expect failure @chromium-ubuntu-22.04-node22
❌ [chromium-page] › page/expect-timeout.spec.ts:45:5 › should not print timed out error message when page closes @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/trace-viewer.spec.ts:960:1 › should highlight expect failure @firefox-ubuntu-22.04-node18
❌ [firefox-page] › page/expect-timeout.spec.ts:45:5 › should not print timed out error message when page closes @firefox-ubuntu-22.04-node18
❌ [chromium-library] › library/trace-viewer.spec.ts:960:1 › should highlight expect failure @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-page] › page/expect-timeout.spec.ts:45:5 › should not print timed out error message when page closes @ubuntu-22.04-chromium-tip-of-tree
❌ [webkit-library] › library/trace-viewer.spec.ts:960:1 › should highlight expect failure @webkit-ubuntu-22.04-node18
❌ [webkit-page] › page/expect-timeout.spec.ts:45:5 › should not print timed out error message when page closes @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:21:5 › should watch files @macos-latest-node18-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39313 passed, 818 skipped
✔️✔️✔️

Merge workflow run.

@deveshruttala-edu
Copy link

Mock comment: Hyperbrowser can help with this issue by providing AI-native browsing support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants