Skip to content

add second prompt for when a compiler needs config #10419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 1, 2023

Conversation

browntarik
Copy link
Contributor

No description provided.

@browntarik browntarik requested review from Colengms, sean-mcmanus and michelleangela and removed request for Colengms and sean-mcmanus January 25, 2023 22:43
sean-mcmanus

This comment was marked as resolved.

sean-mcmanus

This comment was marked as resolved.

sean-mcmanus

This comment was marked as resolved.

michelleangela
michelleangela previously approved these changes Jan 30, 2023
sean-mcmanus

This comment was marked as resolved.

@sean-mcmanus

This comment was marked as resolved.

@michelleangela

This comment was marked as resolved.

@sean-mcmanus

This comment was marked as resolved.

@sean-mcmanus

This comment was marked as resolved.

@sean-mcmanus

This comment was marked as resolved.

Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but it could use more review/testing.

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the change and let's build the VSIX

@sean-mcmanus sean-mcmanus merged commit 8f55a2e into main Feb 1, 2023
@sean-mcmanus sean-mcmanus deleted the browntarik/adjustCompilerDialogs branch February 1, 2023 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants