Remove -D__building_module(x)=0 workaround. #13621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
approved these changes
May 21, 2025
sean-mcmanus
added a commit
that referenced
this pull request
May 29, 2025
* Remove -D__building_module(x)=0 workaround. (#13621) * add note about C++ Copilot suggestions improvement (#13624) * Update changelog for 1.26.1 (#13627) * Update changelog for 1.26.1 * fix typo (#13630) 1.26.0->1.26.1 * Remove the .type.descriptions since they don't seem to have any effect. (#13648) * Lock the PATH variable which was incorrectly being translated. (#13649) * Fix a couple loc issues. (#13650) --------- Co-authored-by: Luca <[email protected]> Co-authored-by: heartacker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the workaround at #12739 (it's no longer necessary).