-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Dynamic debug config + Telemetry #8876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/vscode-cpptools into elrashed/dynamicLaunch
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
bobbrow
reviewed
Feb 17, 2022
…oft/vscode-cpptools into elrashed/dynamicLaunchNew
why is ${workspaceFolder} removed? In reply to: 1048260223 Refers to: Extension/package.json:261 in 513df2b. [](commit_id = 513df2b, deletion_comment = True) |
bobbrow
reviewed
Feb 22, 2022
bobbrow
reviewed
Feb 22, 2022
bobbrow
reviewed
Feb 22, 2022
bobbrow
reviewed
Feb 22, 2022
sean-mcmanus
previously requested changes
Feb 23, 2022
c2ac9ff
to
a526231
Compare
bobbrow
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to "Run and Debug" button in debug panel to make it consistent with our play button:
keeping the Debug info in memory and skip writing it in launch.json
if the launch.json exists try to read the debug configs to check if the user has modified any debug info
Telemetry is added for both
DebugPanel
andplayButton
.the debug configurations are resolved for
playButton
as well.the recently used task is shared between
DebugPanel
andplayButton
.in refactoring, some code between two
DebugPanel
andplayButton
is reused so that they behave the same.Fixes are added for single-mode file debugging, however, it is only working for cl.exe builds and msvc debugger for now.
@jureid Telemetry will be as below:
there are two debuggerEvent:
both events will have these values:
in config these are the 3 different modes (feel free to suggest more meaningful names):
Feature Request: #8773