Skip to content

Dynamic debug config + Telemetry #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Feb 23, 2022
Merged

Dynamic debug config + Telemetry #8876

merged 34 commits into from
Feb 23, 2022

Conversation

elahehrashedi
Copy link
Contributor

@elahehrashedi elahehrashedi commented Feb 17, 2022

Modification to "Run and Debug" button in debug panel to make it consistent with our play button:

  1. keeping the Debug info in memory and skip writing it in launch.json

  2. if the launch.json exists try to read the debug configs to check if the user has modified any debug info

  3. Telemetry is added for both DebugPanel and playButton.

  4. the debug configurations are resolved for playButton as well.

  5. the recently used task is shared between DebugPanel and playButton.

  6. in refactoring, some code between two DebugPanel and playButton is reused so that they behave the same.

  7. Fixes are added for single-mode file debugging, however, it is only working for cl.exe builds and msvc debugger for now.

@jureid Telemetry will be as below:

there are two debuggerEvent:

  • "debugPanel" (the run and debug in debug panel)
  • "launchPlayButton" (our play button)

both events will have these values:

{
"debugType": debug / run
"folderMode":  folder / singleFile
"config": noBuildConfig / noLaunchConfig / launchConfig
"success":  true/false
"cancelled": true
}

in config these are the 3 different modes (feel free to suggest more meaningful names):

  • noBuildConfig: when the build config is not available.
  • noLaunchConfig: when we don't have a launch config and we launch from memory (dynamic mode)
  • launchConfig: when the user has modified the launch.json config and we are using that.

Feature Request: #8773

@elahehrashedi elahehrashedi requested a review from a team February 17, 2022 04:43
@bobbrow
Copy link
Member

bobbrow commented Feb 22, 2022

      "${workspaceFolder}"

why is ${workspaceFolder} removed?


In reply to: 1048260223


Refers to: Extension/package.json:261 in 513df2b. [](commit_id = 513df2b, deletion_comment = True)

@elahehrashedi elahehrashedi force-pushed the elrashed/dynamicLaunchNew branch from c2ac9ff to a526231 Compare February 23, 2022 17:35
@bobbrow bobbrow merged commit f809a81 into main Feb 23, 2022
@bobbrow bobbrow deleted the elrashed/dynamicLaunchNew branch February 23, 2022 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants