Skip to content

Fix bug: !err && stats && stats.isFile will always return true. Fix typos #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

inlann
Copy link
Contributor

@inlann inlann commented Feb 21, 2022

Hello:

I found the if(!err && stats && stats.isFile) in the src/Debugger/configurationProvider will always return true. It should be if(!err && stats && stats.isFile()).

Also found some typos and fixed them 😄

@ghost
Copy link

ghost commented Feb 21, 2022

CLA assistant check
All CLA requirements met.

@inlann
Copy link
Contributor Author

inlann commented Feb 21, 2022

Hello:

Do I need to review it myself or wait for someone?

@bobbrow
Copy link
Member

bobbrow commented Feb 22, 2022

We will review and commit it. Monday was a holiday for MSFT so no one had a chance to look yet.

@inlann
Copy link
Contributor Author

inlann commented Feb 23, 2022

Thanks 😄

BTW: I cloned the source code of cpptools and debugged it in VSCode via F5. But I got the binary missing error:

Unable to start the C/C++ language server. IntelliSense features will be disabled. Error: Missing binary at /Users/mac/Work/vscode-cpptools-inlann/Extension/bin/cpptools

image

I checked the cpptools vsix package downloaded from ms market and there are two executable files cpptools and cpptools-srv in the bin folder. How can I generate them if I modify the source code of the extension?

@sean-mcmanus
Copy link
Contributor

Thanks 😄

BTW: I cloned the source code of cpptools and debugged it in VSCode via F5. But I got the binary missing error:

Unable to start the C/C++ language server. IntelliSense features will be disabled. Error: Missing binary at /Users/mac/Work/vscode-cpptools-inlann/Extension/bin/cpptools

image

I checked the cpptools vsix package downloaded from ms market and there are two executable files cpptools and cpptools-srv in the bin folder. How can I generate them if I modify the source code of the extension?

See https://github.com/microsoft/vscode-cpptools/blob/main/Documentation/Building%20the%20Extension.md

@inlann
Copy link
Contributor Author

inlann commented Feb 23, 2022

See https://github.com/microsoft/vscode-cpptools/blob/main/Documentation/Building%20the%20Extension.md

Thank you for your response!

The document says I need to download the cpptools extension from the Visual Studio Marketplace and copy its binaries cpptools and cpptools-srv into my bin folder. Does this mean that I do not need to generate the cpptools and cpptools-srv binaries myself even if I modify the typescript source code in src directory?

@bobbrow bobbrow merged commit 9ea7328 into microsoft:main Feb 23, 2022
@sean-mcmanus
Copy link
Contributor

@inlann Yes, you can't generate the cpptools and cpptools-srv binaries -- changing the TypeScript doesn't affect the binaries.

@inlann
Copy link
Contributor Author

inlann commented Feb 26, 2022

@sean-mcmanus Thanks so much 😄 That's really helpful

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants