Skip to content

Fix problem with undoing entire stack #10018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Feb 10, 2020

If you save a file, then undo back to when the undo stack is empty, the file should be dirty.

VS code will show the dirty icon on the file, but we won't enable the save button on the UI.

@rchiodo rchiodo added the no-changelog No news entry required label Feb 10, 2020
@rchiodo rchiodo self-assigned this Feb 10, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@97ad678). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor   #10018   +/-   ##
===================================================
  Coverage                    ?    60.8%           
===================================================
  Files                       ?      564           
  Lines                       ?    29882           
  Branches                    ?     4491           
===================================================
  Hits                        ?    18171           
  Misses                      ?    10718           
  Partials                    ?      993
Impacted Files Coverage Δ
...tascience/interactive-ipynb/nativeEditorStorage.ts 55.35% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ad678...3ee78d7. Read the comment docs.

@rchiodo rchiodo merged commit 01e402c into ds/custom_editor Feb 10, 2020
@rchiodo rchiodo deleted the rchiodo/fix_undo_zero branch February 10, 2020 17:40
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants