Skip to content

Update prettier line length to 120 (from 180). #10054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link

As discussed with the team, we're going to try out a line length of 120. This change also removes all "prettier-ignore" directives.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Feb 11, 2020
@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #10054 into master will increase coverage by 0.11%.
The diff coverage is 67.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10054      +/-   ##
==========================================
+ Coverage   61.26%   61.38%   +0.11%     
==========================================
  Files         565      565              
  Lines       30214    30554     +340     
  Branches     4571     4385     -186     
==========================================
+ Hits        18511    18755     +244     
- Misses      10670    10820     +150     
+ Partials     1033      979      -54
Impacted Files Coverage Δ
src/client/common/application/types.ts 100% <ø> (ø) ⬆️
...ger/extension/configuration/providers/pidAttach.ts 100% <ø> (ø) ⬆️
src/client/debugger/types.ts 100% <ø> (ø) ⬆️
...c/client/debugger/extension/configuration/types.ts 100% <ø> (ø) ⬆️
...ommon/terminal/shellDetectors/baseShellDetector.ts 100% <ø> (ø) ⬆️
src/client/common/terminal/types.ts 100% <ø> (ø) ⬆️
src/client/activation/types.ts 100% <ø> (ø) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <ø> (ø) ⬆️
src/client/debugger/extension/adapter/logging.ts 97.14% <ø> (ø) ⬆️
src/client/common/process/types.ts 100% <ø> (ø) ⬆️
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf4955...ccdbfbc. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 35 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@ericsnowcurrently ericsnowcurrently merged commit 649156a into microsoft:master Feb 11, 2020
@ericsnowcurrently ericsnowcurrently deleted the prettier-line-length branch February 11, 2020 22:58
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants