Remove whitespace around code when showing in interactive window #10057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #10057 +/- ##
==========================================
+ Coverage 61.23% 61.26% +0.02%
==========================================
Files 565 565
Lines 30195 30214 +19
Branches 4568 4571 +3
==========================================
+ Hits 18491 18511 +20
+ Misses 10671 10670 -1
Partials 1033 1033
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Feb 11, 2020
DonJayamanne
requested changes
Feb 11, 2020
| @@ -54,6 +54,37 @@ export function splitMultilineString(source: nbformat.MultilineString): string[] | |||
| return []; | |||
| } | |||
|
|
|||
| export function removeLinesFromFrontAndBack(code: string): string { | |||
There was a problem hiding this comment.
I think its good to add unit tests for this function.
There was a problem hiding this comment.
I did. See the tests in cellFactory.unit.test
DonJayamanne
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9116
Do this entirely in the UI as the code submitted has to match the code in the file for cell hashes to match up.