Skip to content

Install jupyter instead of installing kernel spec (#10080) #10083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 12, 2020

  • Install jupyter instead of installing kernel spec
    For #10071

For point release

* Install jupyter instead of installing kernel spec
For #10071
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo
Copy link

rchiodo commented Feb 12, 2020

Shouldn't we wait for the chinese nls fix?

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #10083 into release-2020.02 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.02   #10083      +/-   ##
===================================================
+ Coverage            61.22%   61.23%   +0.01%     
===================================================
  Files                  564      564              
  Lines                30088    30090       +2     
  Branches              4551     4552       +1     
===================================================
+ Hits                 18420    18427       +7     
+ Misses               10636    10632       -4     
+ Partials              1032     1031       -1
Impacted Files Coverage Δ
...interpreter/jupyterInterpreterDependencyService.ts 71.17% <100%> (+5.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d788c...4c1672b. Read the comment docs.

@DonJayamanne DonJayamanne merged commit ffbe5e1 into release-2020.02 Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
@DonJayamanne DonJayamanne deleted the dsFix branch February 24, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants