Skip to content

Further fixes for whitespace #10210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Feb 19, 2020

For #9116

During Ian's validation, he noticed single lines are not treated as such. This fixes that problem.

@rchiodo rchiodo added the no-changelog No news entry required label Feb 19, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #10210 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10210      +/-   ##
==========================================
- Coverage   61.31%   61.31%   -0.01%     
==========================================
  Files         567      567              
  Lines       30770    30770              
  Branches     4410     4410              
==========================================
- Hits        18868    18867       -1     
- Misses      10918    10919       +1     
  Partials      984      984
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 70.58% <0%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf2872...8758520. Read the comment docs.

@rchiodo rchiodo merged commit f1a8f63 into master Feb 19, 2020
@rchiodo rchiodo deleted the rchiodo/fix_whitespace_collapse branch February 19, 2020 20:26
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants