Skip to content

Fix interrupts from always indicating restart #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Feb 20, 2020

For #10050

Interrupt is always indicating a restart even when a restart doesn't occur.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #10228 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10228      +/-   ##
==========================================
+ Coverage   61.21%   61.23%   +0.02%     
==========================================
  Files         567      567              
  Lines       30864    30862       -2     
  Branches     4432     4432              
==========================================
+ Hits        18893    18898       +5     
+ Misses      10987    10981       -6     
+ Partials      984      983       -1
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterNotebook.ts 4.48% <0%> (+0.01%) ⬆️
...c/datascience-ui/react-common/settingsReactSide.ts 22.22% <0%> (ø) ⬆️
src/client/datascience/webViewHost.ts 60.54% <0%> (ø) ⬆️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
src/client/common/process/proc.ts 15.21% <0%> (+0.72%) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (+1.56%) ⬆️
src/client/linters/pydocstyle.ts 88.88% <0%> (+2.22%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d4cf6...9b43cb1. Read the comment docs.

@rchiodo rchiodo merged commit bd9615a into master Feb 20, 2020
@rchiodo rchiodo deleted the rchiodo/fix_interrupt_message branch February 20, 2020 18:03
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants