Skip to content

Fix order of cells inserted #10229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 20, 2020

Cells weren't inserted into the model in the right order.

  • Insert cell using a
  • Insert cell using b
  • Save NB and reopen
  • All the new cells are at the very bottom

Added https://github.com/microsoft/vscode-python/issues/10230 and moved into backlog and assigned to ds_editor epic. I think in light of this issue it must be done. Else it'll be bad for users to report this.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 20, 2020
@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (ds/custom_editor@ca10f93). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             ds/custom_editor   #10229   +/-   ##
===================================================
  Coverage                    ?   60.83%           
===================================================
  Files                       ?      567           
  Lines                       ?    30586           
  Branches                    ?     4363           
===================================================
  Hits                        ?    18608           
  Misses                      ?    11031           
  Partials                    ?      947

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca10f93...c4b8fde. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne
Copy link
Author

Force merging as branch is broken due to CI/GitHub issues (wrong jobs were flagged as Required).

@DonJayamanne DonJayamanne merged commit 14a050d into microsoft:ds/custom_editor Feb 21, 2020
@DonJayamanne DonJayamanne deleted the fixInsertionOfCells branch February 21, 2020 19:55
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants