Rename notebookProvider to notebookEditorProvider #10564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Mar 13, 2020
IanMatthewHuff
approved these changes
Mar 13, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #10564 +/- ##
==========================================
- Coverage 60.76% 60.74% -0.02%
==========================================
Files 578 578
Lines 31355 31355
Branches 4464 4464
==========================================
- Hits 19052 19046 -6
- Misses 11335 11339 +4
- Partials 968 970 +2
Continue to review full report at Codecov.
|
DonJayamanne
added a commit
that referenced
this pull request
Mar 13, 2020
* master: Rename notebookProvider to notebookEditorProvider (#10564)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #10563
Plan is to introduce a
NotebookProviderthat manages the life time of notebooks outside the Native Editor. Hence the need to change properties/variables fromnotebookProvidertonotebookEditorProvider.Besides the actual interface/class is
NotebookEditorProvider, hence changing fromnotebookProvidertonotebookEditorProvideris better and more explicit.Separate PR that introduces renames (else when I do the work, there's a lot of noise in PRs due to renames)