Activate extension if workspace has mspythonconfig #10906
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #10906 +/- ##
==========================================
- Coverage 60.67% 60.65% -0.02%
==========================================
Files 580 580
Lines 31530 31530
Branches 4480 4480
==========================================
- Hits 19131 19125 -6
- Misses 11429 11433 +4
- Partials 970 972 +2
Continue to review full report at Codecov.
|
| @@ -85,7 +85,8 @@ | |||
| "onCommand:python.datascience.selectJupyterInterpreter", | |||
| "onCommand:python.datascience.selectjupytercommandline", | |||
| "onCommand:python.enableSourceMapSupport", | |||
| "onCustomEditor:NativeEditorProvider.ipynb" | |||
| "onCustomEditor:NativeEditorProvider.ipynb", | |||
| "workspaceContains:**/mspythonconfig.json" | |||
There was a problem hiding this comment.
If JSON supported comments I'd ask you to leave one here about the purpose of this activation trigger... 😄 In lieu of that, would you mind making at note somewhere else (e.g. in CONTRIBUTING.md, src/client/extension.ts, or perhaps some new file like PACKAGE_JSON_COMMENTS.md)?
There was a problem hiding this comment.
Not a fan of the prefix ms. Why not pythonconfig.json?
The launch.json and similar files are specific to VSC (Microsoft product), yet we dont prefix with ms..
There was a problem hiding this comment.
However, i understand this is some existing file from another product/package.
There was a problem hiding this comment.
@MikhailArkhipov was there a good reason for the ms prefix? Can we remove it?
There was a problem hiding this comment.
pythonconfig.json is confusing, it makes me believe this is to configure Python while using the extension. mspythonconfig.json sounds more likely to do with the extension, still not clear enough.
There was a problem hiding this comment.
The extension is named ms-python.python-nnnn
So the ms prefix is consistent.
Also, pythonconfig.json is too generic and might conflict with some other extension. Does that make sense?
There was a problem hiding this comment.
Still not sold. Feels more like branding when sticking ms.
If we want a config for the extension in VS Code then how about, codepythonconfig.json, or vss/vscode/pvsc, or similar.
And we might want to put it into ./.vscode folder along with settings.json and launch.json. This way there's no ambiguity about who owns this file.
If it goes into ./.vscode folder I don't see any reason for not naming it pythonconfig.json. At that point it is obvious that it is specific to vscode, automatically our extension.
There was a problem hiding this comment.
This file is read directly by the LS, so I don't think it should be in any editor-specific folder.
This PR is for a specific file (presumably needed by the language server) that is not part of that other PR. |
|
@judej Let me know if I can go ahead with this name for now or should I wait for an updated name. |
No description provided.