Load widget scripts from CDN and/or local python interpreter #10987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Merge change logs from release to master (#10974) Replacing ptvsd with debugpy in remote attach config prompt and contributing guide (#10917) moved vscode-languageclient/server to latest released version (client - 6.1.3, server - 6.1.1) (#10959) Add telemetry for .env files (#10833) Experiments should not block on telemetry. (#10940) Refactor remote debugger script API and tests (#10934) Kernel Launcher and Finder (#10550)
* master: Disable loading scripts from unpkg for widgets (#10938)
* master: Turning reload experiment on for 30% of users (#10868)
Codecov Report
@@ Coverage Diff @@
## master #10987 +/- ##
=======================================
Coverage 61.40% 61.40%
=======================================
Files 597 597
Lines 32752 32752
Branches 4631 4631
=======================================
Hits 20110 20110
Misses 11624 11624
Partials 1018 1018 Continue to review full report at Codecov.
|
* master: Preserve code in cells during execution and edits (#10981) Replace spinner with custom icon when downloading MPLS/Insiders build (#10687) Style speedups for the monaco editor (#11014) Force kernel syncing (#10955) Consolidate the info for internal scripts to one place. (#10876) Update experiments json to include ipywidgets (#10992) Separate Python env from exec. (#10883) Secondary fix for 9523 - Exception for loading should show in the ouptut (#10990)
* master: Remove unnecessary news files add kernel experiment (#10820) (#11013) Fix news entries Attempt 3 for fix interpreter mismatch in notebook (#11010) Actually fix the click on markdown Use clone deep and assume it's a full interpreter Add news entries Attempt to fix interpreter mismatch in another branch
* master: Add cancellation support to node based python LS server (#10784) Run all extension-internal uses of Python "isolated". (#10943) Initialize notebook metadata in the correct place and in alphabetical order (#11016) Update auto save for focus changes to include more cases (#11026) Fix hygiene issue Remove checking for ZMQ from normal execution. Deprecate PythonPath - Part 1 (#11011) Run extension-internal scripts "isolated". (#10941) Fix ipywidget ci test failures (#11025) Remove the unnecessary EnvFileTelemetry namespace (#11007)
DonJayamanne
changed the title
* local3: Fixes Misc changes Fix casing
* master: Put back the daemon code. It's not actually starting a python process. (#11038) Replace "python_node_server" with "language_server" event name (#11033)
DonJayamanne
commented
Apr 9, 2020
DonJayamanne
commented
Apr 9, 2020
DonJayamanne
commented
Apr 9, 2020
src/client/datascience/ipywidgets/ipyWidgetScriptSourceProvider.ts
Outdated
Show resolved
Hide resolved
* master: Fix background (again) for ipywidgets (#11062) Huge perf improvement on windows to functional tests. From 20 minutes down to 4. (#11054) Update master version (#11055) Release prep updates change logs, tpn, and version (#11029) Hide "untrusted" interpreters from 'Select interpreter' dropdown list (#11047) Add more telemetry around ipywidgets (#11034)
IanMatthewHuff
approved these changes
Apr 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
added a commit
that referenced
this pull request
Apr 13, 2020
* Address sonar issues * Fix linter * Fixes * Better way to pas array buffer * Added comments * Oops
DonJayamanne
added a commit
that referenced
this pull request
Apr 14, 2020
* Load widget scripts from CDN and/or local python interpreter (#10987) * Address sonar issues * Fix linter * Fixes * Better way to pas array buffer * Added comments * Oops * Copy widget scripts to extension folder (#11082) * Copy widget scripts to extension folder * Fix test * Remove aml scripts from extension (#11085) * Validate python when nb opened not on extension activates (#11087) For #10893 * Support workspace images in markdown cells (#11086) For #10893 * Fix functional tests for ipywidgets and download just chrome b… (#11093) For #11092 playwright downloads other browsers, we need just one chrome (as this is closest to what VSCode is built upon) * Added tests for k3d widget (#11133) For #10799, #11096 * Fix failing ipywidget tests (#11132) For #11099 * Update change log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10890
@rchiodo @IanMatthewHuff Want to get this reviewed before I complete the rest as there's a lot happening in this one PR (should have split it, but all related - loading widget scripts and handling that).
Pending items
Heres' the structure of the code: