Skip to content

add kernel experiment (#10820) #11013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Conversation

IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Apr 7, 2020

Porting my addition of the experiment for ZMQ from ds/rawKernel into master. Experiment needs to be in master so that it gets downloaded and cached. Then I can actually use the experiment in the ds/rawKernel branch.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Apr 7, 2020
@IanMatthewHuff
Copy link
Member Author

This is just a port of the experiment that I added in ds/rawKernel to master. Same issue as @rchiodo was hitting in that it needs to be in master so that I can actually use / reference it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Apr 7, 2020

Codecov Report

Merging #11013 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11013      +/-   ##
==========================================
- Coverage   60.77%   60.76%   -0.02%     
==========================================
  Files         582      582              
  Lines       31774    31777       +3     
  Branches     4522     4523       +1     
==========================================
- Hits        19312    19308       -4     
- Misses      11476    11481       +5     
- Partials      986      988       +2     
Impacted Files Coverage Δ
src/client/common/experimentGroups.ts 100.00% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0877ca...62427eb. Read the comment docs.

@IanMatthewHuff
Copy link
Member Author

Only fail is windows timeout, so pushing.

@IanMatthewHuff IanMatthewHuff merged commit 3e52696 into master Apr 7, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/ZMQExperimentPort branch June 10, 2020 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants