Skip to content

Fix ipywidget ci test failures #11025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2020
Merged

Fix ipywidget ci test failures #11025

merged 2 commits into from
Apr 8, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 8, 2020

Seems our ipywidget tests are too flakey with respect to recording messages to playback.

Disabling the tests unless running with a full jupyter where the widgets will actually be installed.

@rchiodo
Copy link
Author

rchiodo commented Apr 8, 2020

Example failures:
https://dev.azure.com/ms/vscode-python/_build/results?buildId=72561&view=ms.vss-test-web.build-test-results-tab&runId=2223832&resultId=100291&paneView=debug

@rchiodo rchiodo self-assigned this Apr 8, 2020
@rchiodo rchiodo added the no-changelog No news entry required label Apr 8, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo rchiodo merged commit acb2d8d into master Apr 8, 2020
@rchiodo rchiodo deleted the rchiodo/ipywidgets_test_failures branch April 8, 2020 17:44
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

@rchiodo rchiodo

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rchiodo @IanMatthewHuff @DonJayamanne