Skip to content

Hide "untrusted" interpreters from 'Select interpreter' dropdown list #11047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Apr 9, 2020

For #11046

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #11047 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11047      +/-   ##
==========================================
- Coverage   61.32%   61.24%   -0.08%     
==========================================
  Files         591      593       +2     
  Lines       32380    32491     +111     
  Branches     4586     4593       +7     
==========================================
+ Hits        19856    19900      +44     
- Misses      11523    11587      +64     
- Partials     1001     1004       +3     
Impacted Files Coverage Δ
...t/interpreter/configuration/interpreterSelector.ts 72.94% <100.00%> (+2.42%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/jupyter/jupyterExecution.ts 49.36% <0.00%> (-2.32%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...rc/client/activation/node/languageClientFactory.ts 38.09% <0.00%> (-1.91%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/activation/node/languageServerProxy.ts 30.15% <0.00%> (-1.43%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95f454...feb3082. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.5% 0.5% Duplication

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a small question about telemetry.

Also, please make sure to resolve the "code smell" reported by sonarcloud.

@karrtikr karrtikr merged commit ea5c808 into microsoft:master Apr 9, 2020
@karrtikr karrtikr deleted the interpreterlist branch April 9, 2020 18:30
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants