Skip to content

Fix scrolling in the monaco editor #11089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Fix scrolling in the monaco editor #11089

merged 2 commits into from
Apr 11, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 10, 2020

For #10952

Problems with scrolling on new line (caused by scroll handler being called before the line was actually there)

Problems with scrolling when typing as opposed to just up/down arrow. (caused by scroll handler not waiting for the text to appear so scrolling to a visible line that gets destroyed)

Also fixed a bug in my style speedup code. Sometimes there are no visible lines. In that case, don't remember the default of 18PX.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11089 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11089      +/-   ##
==========================================
- Coverage   61.42%   61.39%   -0.03%     
==========================================
  Files         597      597              
  Lines       32756    32756              
  Branches     4631     4631              
==========================================
- Hits        20121    20112       -9     
- Misses      11619    11626       +7     
- Partials     1016     1018       +2     
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
...ence/ipywidgets/localWidgetScriptSourceProvider.ts 88.13% <0.00%> (-3.39%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 11.61% <0.00%> (ø)
...atascience/interactive-window/interactiveWindow.ts 15.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d13fa2...45a2ff4. Read the comment docs.

@rchiodo rchiodo merged commit 022fe05 into master Apr 11, 2020
@rchiodo rchiodo deleted the rchiodo/newline_scroll branch April 11, 2020 00:13
rchiodo added a commit that referenced this pull request Apr 11, 2020
* Fix monaco editor scrolling and line height

* Add news entry
@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants