-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Address conda environment parsing issues #11103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11103 +/- ##
==========================================
- Coverage 61.41% 61.40% -0.01%
==========================================
Files 596 596
Lines 32848 32851 +3
Branches 4655 4657 +2
==========================================
- Hits 20172 20171 -1
- Misses 11658 11661 +3
- Partials 1018 1019 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Only
base
environment will have*
betweenname
andpath
.
Either the assumption or the comment is incorrect.
1e5884f
to
7759e8a
Compare
Kudos, SonarCloud Quality Gate passed!
|
For #10942
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).I looked into this as a part of investigating #10942, since the env list does not have clear separators between name and paths. Since spaces are allowed to in both paths and names, there are some cases where it is not clear ow to extract the name. This is best effort. I wanted to capture the algorithm before I forget.
Another thing in this change is that I removed the stateless helper class.