Skip to content

Address conda environment parsing issues #11103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

karthiknadig
Copy link
Member

For #10942

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

I looked into this as a part of investigating #10942, since the env list does not have clear separators between name and paths. Since spaces are allowed to in both paths and names, there are some cases where it is not clear ow to extract the name. This is best effort. I wanted to capture the algorithm before I forget.

Another thing in this change is that I removed the stateless helper class.

@karthiknadig karthiknadig requested a review from kimadeline April 11, 2020 08:13
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #11103 into master will decrease coverage by 0.00%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11103      +/-   ##
==========================================
- Coverage   61.41%   61.40%   -0.01%     
==========================================
  Files         596      596              
  Lines       32848    32851       +3     
  Branches     4655     4657       +2     
==========================================
- Hits        20172    20171       -1     
- Misses      11658    11661       +3     
- Partials     1018     1019       +1     
Impacted Files Coverage Δ
...lient/interpreter/locators/services/condaHelper.ts 94.87% <94.59%> (+3.69%) ⬆️
...ient/interpreter/locators/services/condaService.ts 85.55% <100.00%> (-0.08%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-5.89%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/constants.ts 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab579f...7759e8a. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review April 13, 2020 07:34
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Only base environment will have * between name and path.

Either the assumption or the comment is incorrect.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@karthiknadig karthiknadig requested a review from kimadeline April 14, 2020 01:27
@karthiknadig karthiknadig merged commit 46723ff into microsoft:master Apr 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@karthiknadig karthiknadig deleted the issue10942 branch April 28, 2020 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants