Skip to content

Port perf fix to release branch #11144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2020
Merged

Port perf fix to release branch #11144

merged 3 commits into from
Apr 14, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 14, 2020

See original PR:
#11142

rchiodo and others added 2 commits April 13, 2020 17:24
@rchiodo
Fix code lens perf for interactive window (#11142)
e743ade 
* Eliminate first level of redundancy

* Working with a cache

* Add test to verify no more generating cell ranges

* Add news entry

* Clean up on closing

* Make sure close and reopen works

* Fix sonar errors

* Fix restart

* Fix wrong IDisposable type

* Rename restartedKernel to onKernelRestarted

* Recompute when changing settings

* Clear out document close event when document closes
@rchiodo
Update changelog
1658ee6
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11144 into release-2020.04 will decrease coverage by 0.04%.
The diff coverage is 39.28%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.04   #11144      +/-   ##
===================================================
- Coverage            61.41%   61.37%   -0.05%     
===================================================
  Files                  597      596       -1     
  Lines                32761    32786      +25     
  Branches              4633     4642       +9     
===================================================
  Hits                 20121    20121              
- Misses               11624    11645      +21     
- Partials              1016     1020       +4
Impacted Files Coverage Δ
src/client/datascience/cellFactory.ts 64.28% <ø> (ø)
...active-common/intellisense/intellisenseProvider.ts 36.92% <0.00%> (ø)
.../datascience/interactive-common/interactiveBase.ts 5.61% <0.00%> (-0.01%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 11.56% <0.00%> (-0.05%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 15.48% <0.00%> (ø)
...cience/jupyter/jupyterCellOutputMimeTypeTracker.ts 78.68% <0.00%> (-1.32%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 4.21% <0.00%> (-0.01%) ⬇️
src/client/datascience/types.ts 100.00% <ø> (ø)
src/client/telemetry/importTracker.ts 86.13% <0.00%> (-0.87%) ⬇️
...ient/datascience/editor-integration/codewatcher.ts 60.72% <37.50%> (+0.14%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c627c...f3a58c7. Read the comment docs.

@rchiodo rchiodo merged commit 02fa068 into release-2020.04 Apr 14, 2020
@rchiodo rchiodo deleted the rchiodo/port_release branch April 14, 2020 15:59
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rchiodo @codecov-io @IanMatthewHuff