Skip to content

Update timeout for windows PR validation #11147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

karthiknadig
Copy link
Member

Looks like after updating to Jedi 0.16.0 we are running into timeout with Windows Single work-space runs. I am increasing the timeout temporarily until we figure out why.

@karthiknadig karthiknadig added the no-changelog No news entry required label Apr 14, 2020
@karthiknadig karthiknadig requested a review from karrtikr April 14, 2020 06:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #11147 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11147      +/-   ##
==========================================
- Coverage   61.47%   61.39%   -0.08%     
==========================================
  Files         597      596       -1     
  Lines       32801    32847      +46     
  Branches     4640     4654      +14     
==========================================
+ Hits        20163    20166       +3     
- Misses      11622    11661      +39     
- Partials     1016     1020       +4     
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
.../datascience/editor-integration/codeLensFactory.ts 52.56% <0.00%> (-6.21%) ⬇️
...ence/ipywidgets/localWidgetScriptSourceProvider.ts 88.13% <0.00%> (-3.39%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/activation/languageClientMiddleware.ts 31.97% <0.00%> (-1.63%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...cience/jupyter/jupyterCellOutputMimeTypeTracker.ts 78.68% <0.00%> (-1.32%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/telemetry/importTracker.ts 86.13% <0.00%> (-0.87%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56051b8...c3b33ac. Read the comment docs.

@DonJayamanne
Copy link

Looks like after updating to Jedi 0.16.0 we are running in

This was always the case, since we refactored CI.
Previously the timeout was 120 or 180 (@karrtikr might remember).
Lol, we thought we fixed it, but we didn't (#10293)

@karrtikr
Copy link

@DonJayamanne Yes, but it almost always happens nowadays. Something may have triggered it.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation pipeline is still failing.. please don't merge until it passes.

@karthiknadig
Copy link
Member Author

We split the functional and single to run on separate machines, with #10293. Ian made the split. It was working better until we switched to Jedi 0.16.0 and we have data both from our users that switching to jedi 0.16.0 slowed down startup time. When we switch over to github actions we are going to have tests that run on specific are for PR and CI will run the whole thing.

@karthiknadig karthiknadig marked this pull request as ready for review April 14, 2020 20:21
@karthiknadig karthiknadig requested a review from karrtikr April 14, 2020 20:21
@karthiknadig karthiknadig merged commit eccc9fc into microsoft:master Apr 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@karthiknadig karthiknadig deleted the timeout branch April 28, 2020 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants