Fix failing unit tests on windows #11191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
requested review from
ericsnowcurrently,
DonJayamanne,
karthiknadig and
kimadeline
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
approved these changes
Apr 15, 2020
kimadeline
approved these changes
Apr 15, 2020
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Apr 20, 2020
karthiknadig
added a commit
that referenced
this pull request
Apr 20, 2020
Co-authored-by: Rich Chiodo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI build has been failing since last thursday for the 6 tests fixed by this change.
https://dev.azure.com/ms/vscode-python/_build/results?buildId=74001&view=ms.vss-test-web.build-test-results-tab&runId=2243262&resultId=104539&paneView=debug
We have a need to share the insider's so I thought I'd just fix them. Assuming this passes on linux/mac as well, I think we don't need to convert the file paths to unix.