Fixes to telemetry Keyboard and mouse nb telemetry #11220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
DavidKutu and
greazer
DonJayamanne
commented
Apr 16, 2020
| @@ -305,70 +304,40 @@ export enum Telemetry { | |||
| } | |||
|
|
|||
| export enum NativeKeyboardCommandTelemetry { | |||
| AddToEnd = 'DATASCIENCE.NATIVE.KEYBOARD.ADD_TO_END', | |||
There was a problem hiding this comment.
Some of these cannot be done using keyboard, only possible via mouse clicks (hmm, highlights accessibility issues)
There was a problem hiding this comment.
Our accessibility is rough, but pretty soon a big chunk of that will be on the VS Code notebook editor.
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
commented
Apr 16, 2020
| } | ||
| break; | ||
| case 'l': | ||
| if (!this.isFocused() && this.isSelected()) { | ||
| e.stopPropagation(); | ||
| e.preventDefault(); | ||
| this.props.toggleLineNumbers(cellId); | ||
| this.props.sendCommand(NativeCommandType.ToggleLineNumbers, 'keyboard'); | ||
| this.props.sendCommand(NativeKeyboardCommandTelemetry.ToggleLineNumbers); |
There was a problem hiding this comment.
The telemetry tells us whether its keyboard/mouse, hence we don't need the command argument either.
IanMatthewHuff
approved these changes
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10809