Error line numbers coming out with invalid values #11234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
requested review from
IanMatthewHuff,
DonJayamanne,
greazer and
DavidKutu
DavidKutu
approved these changes
Apr 17, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #11234 +/- ##
==========================================
- Coverage 61.37% 61.08% -0.30%
==========================================
Files 604 601 -3
Lines 33528 33108 -420
Branches 4746 4678 -68
==========================================
- Hits 20577 20223 -354
+ Misses 11894 11865 -29
+ Partials 1057 1020 -37
Continue to review full report at Codecov.
|
|
Sorry got wrapped up in the bug bash. I can look early monday. |
IanMatthewHuff
approved these changes
Apr 20, 2020
| let sourceLines = ''; | ||
| const regex = /(;32m[ ->]*?)(\d+)(.*)/g; | ||
| for (let l = regex.exec(traceFrame); l && l.length > 3; l = regex.exec(traceFrame)) { | ||
| const newLine = stripAnsi(l[3]).substr(1); // Seem to have a space on the front |
There was a problem hiding this comment.
Comments like this make me worry this is a bit fragile of a process. But I don't see a way around it, so it might just be what we have to do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10708
Number of problems here.
Old code assumed that if the file in the error message matched the cell, it was the cell. This doesn't work if the exception is thrown in a different cell that's been referenced (as it will have the same file). The example for this is in the bug.
Old code also didn't take into account extra spacing at the top of a cell.
New code uses the cell hash provider to look for the closest match to the source code in the stack trace (if the file matches a file that we ran cells from).
Note that this may find invalid cells if they have duplicate code in them. Don't see a way around this without getting rid of the
__file__support. An exception doesn't log any other information other than the code in the traceback.