Skip to content

Remove unsupported translations #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

karthiknadig
Copy link
Member

Currently we don't have a way to get language files updated every time we add a new string or update existing strings. Whenever we add a new language there are additional documents that need translation as well. Currently we don't have those translations for farsi and hindi, due to small user base. It is unfortunate that we have to remove these translations. Hopefully, if the user base gets large enough we can add support for these languages.

@karthiknadig karthiknadig added the no-changelog No news entry required label Apr 20, 2020
@karthiknadig karthiknadig marked this pull request as ready for review April 20, 2020 18:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11261 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11261      +/-   ##
==========================================
- Coverage   61.12%   61.09%   -0.03%     
==========================================
  Files         601      601              
  Lines       33125    33125              
  Branches     4680     4680              
==========================================
- Hits        20246    20239       -7     
- Misses      11861    11866       +5     
- Partials     1018     1020       +2     
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b1a81...4572419. Read the comment docs.

@karthiknadig karthiknadig merged commit 33e4c99 into microsoft:master Apr 20, 2020
@karthiknadig karthiknadig deleted the remove-lang branch April 28, 2020 23:37
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants