Skip to content

Connection type refactor #11272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2020
Merged

Connection type refactor #11272

merged 4 commits into from
Apr 20, 2020

Conversation

IanMatthewHuff
Copy link
Member

For #11195

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Apr 20, 2020
IanMatthewHuff
IanMatthewHuff commented Apr 20, 2020
View reviewed changes
src/client/datascience/types.ts
readonly baseUrl: string;
readonly token: string;
readonly hostName: string;
localProcExitCode: number | undefined;
allowUnauthorized?: boolean;
}

export type INotebookProviderConnection = IRawConnection | IJupyterConnection;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This right here is the crux of the change.

  1. Rename IConnection -> IJupyterConnection
  2. Top level connection type is now type union
  3. Lets me remove some ugly spots where I was doing an as cast and lets me just pass the type

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMatthewHuff
Copy link
Member Author

@rchiodo had good feedback on a type change from the big merge in from rawKernel. But I didn't want to change a whole bunch more files in that painful merge. So adding it in this follow up PR.

rchiodo
rchiodo approved these changes Apr 20, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff
Copy link
Member Author

Only single workspace timeout

@IanMatthewHuff IanMatthewHuff merged commit 59b1a81 into microsoft:master Apr 20, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/connectionRefactor branch April 20, 2020 18:03
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@greazer greazer Awaiting requested review from greazer

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanMatthewHuff @rchiodo