Skip to content

Raw Session Telemetry #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IanMatthewHuff
Copy link
Member

For #11320

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Apr 23, 2020
@codecov-io
Copy link

codecov-io commented Apr 23, 2020

Codecov Report

Merging #11355 into master will decrease coverage by 0.04%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11355      +/-   ##
==========================================
- Coverage   61.05%   61.00%   -0.05%     
==========================================
  Files         604      606       +2     
  Lines       33418    33465      +47     
  Branches     4732     4729       -3     
==========================================
+ Hits        20402    20416      +14     
+ Misses      12575    12025     -550     
- Partials      441     1024     +583     
Impacted Files Coverage Δ
src/client/telemetry/index.ts 87.38% <ø> (ø)
...client/datascience/raw-kernel/rawJupyterSession.ts 71.21% <50.00%> (+1.37%) ⬆️
src/client/datascience/constants.ts 99.72% <100.00%> (+<0.01%) ⬆️
src/client/datascience/jupyter/jupyterServer.ts 9.70% <100.00%> (+2.77%) ⬆️
...client/datascience/kernel-launcher/kernelFinder.ts 62.24% <0.00%> (-16.11%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/activation/activationService.ts 87.35% <0.00%> (-0.88%) ⬇️
src/client/activation/serviceRegistry.ts 82.71% <0.00%> (-0.83%) ⬇️
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ea303...deabc18. Read the comment docs.

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit 3e2357f into microsoft:master Apr 23, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/rawKernelLaunchTelemetry branch April 23, 2020 16:49
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants